Bug 1388493

Summary:	Console should continue if error encountered gathering metrics
Product:	OpenShift Container Platform	Reporter:	Matt Wringe <mwringe>
Component:	Management Console	Assignee:	Samuel Padgett <spadgett>
Status:	CLOSED ERRATA	QA Contact:	Yadan Pei <yapei>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.3.0	CC:	aos-bugs, jforrest, jokerman, mmccomas, spadgett, tdawson, yanpzhan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	The web console handling of error responses from Hawkular Metrics was made more robust. The web console will retry on the first error updating the metrics charts. If errors persist, the web console will show an alert at the top of the page with a "Retry" link. This also lets you continue viewing metrics already fetched if a later error occurrs updating the data.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-04-12 19:07:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Matt Wringe 2016-10-25 13:40:34 UTC

Description of problem:
The console periodically gathers metrics from the Hawkular Metrics endpoint. If an error is encountered, this will stop any further gathering of metrics.

This means for the console to start displaying metrics again, the user has to reload their browser or change console tabs.

It would be beneficial if the console could handle this situation in a better manner. We should be trying to gather metrics at the next interval in case the error has resolved itself, as well as potentially retrying once right after an error occurred.

Comment 1 Samuel Padgett 2016-11-28 17:15:55 UTC

https://github.com/openshift/origin-web-console/pull/930

Comment 2 openshift-github-bot 2016-11-28 19:31:41 UTC

Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/5c580bb8a7f85d952a35b39b9e8caca44c1c071d
Bug 1388493 - Better handling of metrics errors

If the first request for metrics fails, show an empty state error message.
Otherwise show an alert if more than one consecutive request fails. The
alert has a retry link.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1388493

Comment 3 Yadan Pei 2016-12-05 06:00:57 UTC

Will check when new puddle is ready

Comment 4 Yanping Zhang 2016-12-05 10:40:34 UTC

Which OCP puddle contains the fix for the bug? And to verify the bug, what kind of error should I simulate so that I can see the alert info?

Comment 5 Samuel Padgett 2016-12-05 12:51:36 UTC

Sorry, I thought the bug was opened against origin. Changing status to MODIFIED.

Comment 6 Troy Dawson 2017-01-20 23:00:34 UTC

This has been merged into ocp and is in OCP v3.5.0.7 or newer.

Comment 7 Yanping Zhang 2017-01-22 10:27:19 UTC

Checked on OCP v3.5.0.7
Check pod's metrics on web console, metrics chart is updated periodically when metrics endpoint is working. When the metrics endpoint doesn't work, the pod metrics chart won't update and when gather metrics at the next interval, there is an alert info showing with a "Retry" link, user could click it to retry, once the metrics endpoint is ok, the error will disappear:
"An error occurred updating metrics for pod nodejs-1-d7php. Retry"

The bug has been fixed, so move it to verified.

Comment 9 errata-xmlrpc 2017-04-12 19:07:41 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0884