Bug 1388626
| Summary: | When adding text boxes to service dialogs, the visible field is unchecked by default | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | cwyatt | ||||
| Component: | UI - OPS | Assignee: | Allen W <awight> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Shveta <sshveta> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 5.7.0 | CC: | awight, gmccullo, hkataria, jhardy, mpovolny, obarenbo, simaishi | ||||
| Target Milestone: | GA | Keywords: | TestOnly | ||||
| Target Release: | 5.8.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | service:dialog | ||||||
| Fixed In Version: | 5.8.0.0 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1391986 (view as bug list) | Environment: | |||||
| Last Closed: | 2017-06-12 16:32:30 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1391986 | ||||||
| Attachments: |
|
||||||
Greg, Should we make textbox field visible by default, please let me know so i can reassign this BZ. Thanks, ~Harpreet Yes, it should be visible by default. The modeling does that here using default_value_for: https://github.com/ManageIQ/manageiq/blob/3f63dbb8dbda6f5afbf2a04aeba22771ab313c47/app/models/dialog_field.rb#L16 New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/8097ada9aaec69f63592d7a2cdf4b6ad94b61d22 commit 8097ada9aaec69f63592d7a2cdf4b6ad94b61d22 Author: Allen Wight <allen.b.wight> AuthorDate: Wed Oct 26 11:14:20 2016 -0400 Commit: Allen Wight <allen.b.wight> CommitDate: Wed Oct 26 11:14:20 2016 -0400 Set default value of param visible to true for all dialog types https://bugzilla.redhat.com/show_bug.cgi?id=1388626 https://trello.com/c/TJKACsZb/37-https-bugzilla-redhat-com-show-bug-cgi-id-1388626 app/controllers/miq_ae_customization_controller/dialogs.rb | 3 +++ 1 file changed, 3 insertions(+) New commit detected on ManageIQ/manageiq/euwe: https://github.com/ManageIQ/manageiq/commit/1bac23694f2d75f903736df993e47190ad7b2f44 commit 1bac23694f2d75f903736df993e47190ad7b2f44 Author: Greg McCullough <gmccullo> AuthorDate: Thu Oct 27 13:15:27 2016 -0400 Commit: Oleg Barenboim <chessbyte> CommitDate: Tue Nov 1 11:47:32 2016 -0400 Merge pull request #12206 from AllenBW/bug/1388626-service-dialog-visble-by-default Set default value of param visible to true for all field types (cherry picked from commit 9f4edee1180527be519b8f1f3d4691f12e2142e8) https://bugzilla.redhat.com/show_bug.cgi?id=1388626 app/controllers/miq_ae_customization_controller/dialogs.rb | 3 +++ 1 file changed, 3 insertions(+) Yeah! sorry about that, updated 👍🏿 Fixed . verified in 5.8.0.4.20170307183144_745a3d9 |
Created attachment 1214048 [details] Default for visible is unchecked Description of problem: When adding text boxes to service dialogs, the visible field is unchecked by default. This is confusing, as it seems like more often than not you will want to field to be visible. The default should be changed so that the "Visisble" field is checked/selected. If the user does not notice the visible field (since it is new) then when they try to fill out the dialog there will not be any field visible Version-Release number of selected component (if applicable): 5.7.0.6-alpha3.20161019140041_ea8e259 How reproducible: 100% Steps to Reproduce: 1. Create a new dialog 2. Add an element 3. Select "Text Box" for the Type Actual results: Expected results: Additional info: