Bug 1388841

Summary: [userinterface_public_691] There is always one pull secret that still exists after removing all pull secrets on DC editor page
Product: OpenShift Container Platform Reporter: Xingxing Xia <xxia>
Component: Management ConsoleAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED CURRENTRELEASE QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.4.0CC: aos-bugs, jokerman, mmccomas
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Adding a two pull secret on the DC editor, saving the DC and removing them in the editor and saving again. Consequence: One pull secret still exists. Fix: Work with the copy of the pull secrets, not directly with the object itself. Result: All pull secrets are removed.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-08 18:34:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Xingxing Xia 2016-10-26 09:47:54 UTC 
Description of problem:
After clicking the "X" buttons of all pull secrets (even if the sum of pull secrets is 1) and Save on DC editor page, there is always one that still exists if we check the DC again (both in CLI and editor page)

Version-Release number of selected component (if applicable):
openshift v3.4.0.15

How reproducible:
Always

Steps to Reproduce:
1. Create dc
$ oc new-app openshift/hello-openshift
2. Create pull secrets:
$ oc secrets new-dockercfg dockerhub --docker-server=private.registry.com --docker-username=any --docker-password=12345678 --docker-email=any
$ oc secrets new-dockercfg newdockerhub --docker-server=private.registry.com --docker-username=any --docker-password=12345678 --docker-email=any

3. Add the pull secrets to DC:
on DC editor page, click "advanced image options" --> pick pull secret dockerhub, pick another pull secret newdockerhub, Save

4. On DC editor page again, click the "X" buttons beside above pull secrets to remove all pull secrets, Save

5. Check pull secrets in DC via CLI or editor page

Actual results:
5. The pull secret dockerhub still exists in DC

Expected results:
5. All pull secrets should be removed

Additional info:
Comment 1 openshift-github-bot 2016-10-27 12:23:03 UTC 
Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/d50209f3cede961b2596ec5af7030e380ae7ceb0
Bug 1388841 - Fix DC editor pullSecrets variable updated
Comment 2 Xingxing Xia 2016-11-01 07:56:31 UTC 
Verified with openshift v3.4.0.18+ada983f. Now all pull secrets can be removed on DC editor page. Thanks!