Bug 1388860

Summary:	[RHV][Add disk]: Delete bootable disk along with add bootable disk fail to add disk.
Product:	Red Hat CloudForms Management Engine	Reporter:	Ilanit Stein <istein>
Component:	Providers	Assignee:	Moti Asayag <masayag>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ilanit Stein <istein>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	5.7.0	CC:	cpelland, jfrey, jhardy, mhild, obarenbo
Target Milestone:	GA	Keywords:	TestOnly
Target Release:	5.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	rhev
Fixed In Version:	5.8.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1393977 (view as bug list)		Environment:
Last Closed:	2017-06-12 17:07:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	RHEVM	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1393977

Description Ilanit Stein 2016-10-26 10:23:57 UTC

Description of problem:
On CFME, RHV VM Reconfigure A VM, that has a bootable disk to
Delete the bootable disk, along with Add a bootable disk, 
in the same request.
The request fail on:
"Error: Fault reason is "Operation Failed". Fault detail is "[Cannot add Virtual Disk. Storage Domain hasn't been specified.]". HTTP response code is 400."

Version-Release number of selected component (if applicable):
CFME-5.7.0.6-alpha3.20161019140041_ea8e259

How reproducible:
100%

Actual results:
The existing bootable disk is removed, but the new bootable disk fail to be added. 

Expected results:
Add a bootable disk in this case should succeed.

Additional info:
Add bootable disk to a VM that has no bootable disks is not supported,
but the case in this bug is different, since the data in the storage is known & kept before the existing bootable disk removal.

Comment 2 Moti Asayag 2016-11-03 18:21:15 UTC

https://github.com/ManageIQ/manageiq/pull/12398

Comment 3 CFME Bot 2016-11-09 23:06:10 UTC

New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/8a6cb6a17e7b8c5654c873d8acb582e48b0de0bd

commit 8a6cb6a17e7b8c5654c873d8acb582e48b0de0bd
Author:     Adam Grare <agrare>
AuthorDate: Wed Nov 9 09:07:08 2016 -0500
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Wed Nov 9 18:04:08 2016 -0500

    Merge pull request #12398 from masayag/pass_storage_domains_in_disk_api_request
    
    Pass storage domains collection in disks RHV api request
    (cherry picked from commit 4e37dc4ba927554aa3199fce228bfe9d32476044)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1388860

 app/models/manageiq/providers/redhat/infra_manager.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 5 Ilanit Stein 2017-05-04 07:14:07 UTC

Verified on CFME-5.8.0.13/RHV-4.1.1.8

VM original bootable disk was removed,
and a new bootable disk was added, 
on the same storage domain of the original bootable disk, 
as expected.