Bug 1388908

The same comments apply as for other reviews: %description should not be indented, don't repeat the %description, or the %summary.

Dot at the end of %description, wrap to ~72 columns.

Summary should be shorter, maybe "Include Bootstrap in your project without boilerplate code".

%license LICENSE.

Hi David,

Please note that there is an open review request for the same package [0], but it has not been active for a while. If you intend to continue the porting effort for this package, please also check out the comments for that review request as they also apply here, especially regarding fonts.

[0] https://bugzilla.redhat.com/show_bug.cgi?id=983843

*** Bug 983843 has been marked as a duplicate of this bug. ***

This package should probably be named "python-flask-bootstrap" (all lower case), in spite of the upstream naming which seems to vary randomly between "Flask Bootstrap", "flask-bootstrap", and "Flask-Bootstrap", because:

* in general Fedora prefers lower case with dash separator: https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#General_Naming
* this is an addon for python-flask so it should follow the "addon" naming convention, using a prefix of "python-flask-"
* all other Flask addon packages are named python-flask-* in lower case so this one should stay consistent with them

Hi,

I fix naming issue : 

Spec URL: https://hvad.fedorapeople.org/fedora/python-Flask-Bootstrap/python-flask-bootstrap.spec

SRPM URL: https://hvad.fedorapeople.org/fedora/python-Flask-Bootstrap/python-flask-bootstrap-3.3.7.0-1.fc25.src.rpm


Could you approved it ? 

Best regard

The Summary cannot just repeat the package name. What about "
Ready-to-use Twitter-bootstrap for use in Flask" or my suggestion from comment #c1?

There's a spurious whitespace at the beginning of %description, and the terminating dot is missing.

http://github.com → https://github.com

This package bundles jquery and bootstrap. The license field must reflect this.
Also you need to add "Provides: bundled(bootstrap)", "Provides: bundled(jquery)".

You must add %license LICENSE.

Hi,

New version of package with fix.

Spec URL: https://hvad.fedorapeople.org/fedora/python-Flask-Bootstrap/python-flask-bootstrap.spec

SRPM URL: https://hvad.fedorapeople.org/fedora/python-Flask-Bootstrap/python-flask-bootstrap-3.3.7.1-1.fc26.src.rpm

There's not LICENSE file in tarball. I open a issue in upstream. 

Best regard

Hmm, fedora-review has trouble. It fails with "path too long" exception. Whatever.

+ package name is OK
+ license is acceptable for Fedora (BSD)
+ license is specified correctly (according to setup.py, individual files have no headers)
+ latest version
+ builds and installs OK
+ P/BR/R look mostly OK, see below
+ modern python packaging template is used
- no %check, but not required

So the only thing that is missing is Provides for bundled js/css stuff.
You certainly need:

Provides: bundled(jquery)

but maybe also some additional stuff, please look at the .js files and identify if there's something that should have another Provides:bundled() annotation.

Oh, and also please fix the Summary to be something different then the package name (and then update the title of this ticket to match).

Package is APPROVED. Please update Provides and Summary before importing.

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-flask-bootstrap

Hi,

I fix license and summary issue. Could you approve ?

https://src.fedoraproject.org/rpms/python-flask-bootstrap

Best regard