Bug 1389010

Summary: GCE Boot Disk Size options should be sorted by actual size
Product: Red Hat CloudForms Management Engine Reporter: Josh Carter <jocarter>
Component: ProvisioningAssignee: Lucy Fu <lufu>
Status: CLOSED CURRENTRELEASE QA Contact: Leo Khomenko <lkhomenk>
Severity: medium Docs Contact:
Priority: high    
Version: 5.7.0CC: cpelland, jhardy, obarenbo
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.9.0   
Hardware: All   
OS: All   
Whiteboard: google:provision:ui
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1449403 1458447 (view as bug list) Environment:
Last Closed: 2018-03-06 14:37:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: GCE Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1449403, 1458447    

Description Josh Carter 2016-10-26 16:23:33 UTC
Description of problem:

GCE  Boot Disk Size options should be sorted by actual size 

first dropdown option is 1TB then the second is 10GB this could cause some customer issues if users are running through the dialogs

Version-Release number of selected component (if applicable):
 Version 5.7.0.7-beta1.20161025153249_9376fbd 

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Greg McCullough 2017-05-01 17:41:35 UTC
Lucy - Reviewing this I think the best solution is for the dialog fields to support a "sort_by => :none" flag which we can add to the "GCE Boot Disk Size" field in the provision dialog.  

Then the field will display in the order they are inserted.  This flag name/setting is inline with the values used in the Service Dialogs:

New field property
:sort_by: :none

Would need to extend the if-condition here to support the new flag for this field:
https://github.com/ManageIQ/manageiq-ui-classic/blob/4f45c537341088d8f1dfba252f4ae77822998bd8/app/views/miq_request/_prov_field.html.haml#L259

Comment 5 CFME Bot 2017-05-03 21:43:23 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/d28172e4408e51be125705880f165bd34246d313

commit d28172e4408e51be125705880f165bd34246d313
Author:     Lucy Fu <lufu>
AuthorDate: Wed May 3 14:58:39 2017 -0400
Commit:     Lucy Fu <lufu>
CommitDate: Wed May 3 15:55:27 2017 -0400

    Check :sort_by: :none to keep the field values in the order that they are inserted in the file.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1389010

 app/views/miq_request/_prov_field.html.haml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comment 6 CFME Bot 2017-05-03 21:46:31 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/b91d017ac76250e12a9a4928e27dd2c51741f513

commit b91d017ac76250e12a9a4928e27dd2c51741f513
Author:     Lucy Fu <lufu>
AuthorDate: Wed May 3 14:44:30 2017 -0400
Commit:     Lucy Fu <lufu>
CommitDate: Wed May 3 15:13:47 2017 -0400

    Add :sort_by: :none to GCE Boot Disk Size dialog field.
    
    Use :sort_by: :none to keep the values in the order that they are inserted in the file.
    https://bugzilla.redhat.com/show_bug.cgi?id=1389010

 product/dialogs/miq_dialogs/miq_provision_google_dialogs_template.yaml | 1 +
 1 file changed, 1 insertion(+)