| Summary: | Allow displaying Calibre's Ebook Viewer in desktop application menus. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Audrey Yeena Toskin <audrey> |
| Component: | calibre | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 31 | CC: | chkr, frankly3d, helio, kevin, nushio, zbyszek |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-11-24 20:20:16 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Audrey Yeena Toskin
2016-10-27 06:20:36 UTC
That change is so calibre only appears once in gnome-software and not 4 times under different names. I'll check with the gnome software folks and see if there's some way to do this that doesn't affect the local launching of those subapps. Keven, were you every able to talk to GNOME developers about a possible workaround?
Or should we call this a bug? Calibre would not be the only package to provide an application suite with multiple .desktop files. LibreOffice is another example.
This GNOME Bugzilla issue looks somewhat related to what we're talking about, though the original post brings up multiple bundled .desktop files in the context of a flatpak instead of an RPM.
https://bugzilla.gnome.org/show_bug.cgi?id=765268
Kevin** sorry No, I haven't come up with any solution here. ;( I talked a bit with a few people, but didn't get a solution. Will see what I can find out. I'm thinking GNOME Software's behavior should probably be considered a bug, so I went ahead and reported the issue to the GNOME Bugzilla. And at least this way we can track the discussion. https://bugzilla.gnome.org/show_bug.cgi?id=776965 ok. I'll follow along there. Should we keep this open in the mean time? If they counter argue the problem is in the Calibre .desktop files and suggest a workaround, then I'll open this bug again. Actually, assuming the GNOME Software developers agree that the bug is in *their* project, you still probably ought to remove the NoDisplay tags from the Calibre .desktop files. What do you think? I'm no longer certain the current behavior in GNOME Software is really a problem, but I *would* still like an easier way to launch the ebook-viewer app. I think it is still an issue, but there's not any solution still. ;( Can you make a local .desktop file to your account and get it working (for you) via that? I could create my own .desktop file, but it seems a little silly to me to use a duplicate copy. I don't know anymore if we're on the same page here: Could you clarify for me what you think the problem is? (In reply to Andrew Toskin from comment #11) > I could create my own .desktop file, but it seems a little silly to me to > use a duplicate copy. It's pretty normal practice to copy a .desktop file to you home directory when you want to override something in the main packaged copy. >I don't know anymore if we're on the same page here: > Could you clarify for me what you think the problem is? You want to be able to launch ebook reader mode of calibre from the overview or another launcher, but currently you can only launch the library view directly from the gui and have to use the command line to launch the ebook viewer. Is that about right? or Did we diverge somewhere here... Right, yes. But I meant I'm not sure if we're on the same page about the *upstream* problem which is preventing you from removing the NoDisplay tags in the Calibre .desktop files. If I did so, "calibre" would appear multiple times in gnome software, and then after the next time the appinfo data is generated would disappear entirely because it's not compliant with the rules. Happy to hear if I missed anything there... > If I did so, "calibre" would appear multiple times in gnome software I'm no longer convinced that that's necessarily a problem. If a user only wanted the ebook editor, they might be surprised to discover that the ebook viewer and collection manager were also installed, like dependencies. But the Calibre suite is correctly installed either way. > and then after the next time the appinfo data is generated would disappear entirely because it's not compliant with the rules. There's a rule somewhere saying that listed applications must only include a single .desktop file? Seems like that would affect many other applications too. Calibre can't be the only one that normally adds extra .desktop files. (In reply to Andrew Toskin from comment #15) ...snip... > There's a rule somewhere saying that listed applications must only include a > single .desktop file? Seems like that would affect many other applications > too. Calibre can't be the only one that normally adds extra .desktop files. Yes, I think that is the case. Those apps that have multiple desktop files must list only one in the appstream data or just not show up. Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle. Changing version to '28'. > apps that have multiple desktop files must list only one in the appstream data
...Could you patch the appstream data? Or something?
I created my own .desktop files a while ago, but it seems silly to me to expect every other user to do this if they want to be able to open the epub reader directly. Opening the Calibre ebook manager itself is awfully slow, and wastes time when all you want is to continue reading a book you already started.
The Packaging Guidelines were revised somewhat recently. https://fedoraproject.org/wiki/Packaging:Guidelines#Application_Independence Notice that this section uses "SHOULD" instead of "MUST". My reading of the Application Independence section suggests that the Calibre ebook readers should ideally just be packaged as separate applications, or at least as subpackages of Calibre itself, if possible. But if that's not possible, because the code really is interdependent, then you're allowed to bundle them all together even with multiple visible .desktop files. So what do you think of the Packaging Guidelines on application independence, linked in my previous comment? This message is a reminder that Fedora 28 is nearing its end of life. On 2019-May-28 Fedora will stop maintaining and issuing updates for Fedora 28. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '28'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 28 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The Fedora Packaging Guidelines have moved to a git repo instead of a wiki, with exported Web pages published in the docs.* subdomain, so I will post the updated URL here: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_independence Again, it seems to me that, according to the latest Guidelines, the Calibre ebook viewers and editors should ideally be separate packages -- perhaps subpackages in a single spec. *If feasible*, each of the Calibre sub-applications should require the shared Calibre libraries instead of requiring the Calibre ebook manager or each other. BUT if separating them is not actually feasible, then it should be okay to keep them bundled like they are now. In any case, whether you split the packages or keep them bundled, I really don't think putting `NoDisplay=true` in the .desktop files is correct or necessary. This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'. This message is a reminder that Fedora 31 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '31'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 31 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 31 changed to end-of-life (EOL) status on 2020-11-24. Fedora 31 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |