Bug 1389299

Summary: [Beta 1] In VM Object, if you click the refresh button (not the browser refresh), it goes one level up in the tree
Product: Red Hat CloudForms Management Engine Reporter: Loic Avenel <lavenel>
Component: UI - OPSAssignee: Zita Nemeckova <znemecko>
Status: CLOSED CURRENTRELEASE QA Contact: Matouš Mojžíš <mmojzis>
Severity: high Docs Contact:
Priority: high    
Version: 5.7.0CC: cpelland, dajohnso, dclarizi, hkataria, jhardy, lkhomenk, mpovolny, mshriver, obarenbo, sbulage, simaishi
Target Milestone: GAKeywords: Regression, TestOnly
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: vm:detail
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1397426 (view as bug list) Environment:
Last Closed: 2017-06-12 16:16:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1392139, 1397426    

Description Loic Avenel 2016-10-27 12:07:18 UTC
Description of problem: In VM  Object, if you click the refresh button (not the browser refresh), it goes one level up in the tree


Version-Release number of selected component (if applicable): 5.7.0.7-beta1.20161025153249_9376fbd


How reproducible: Always


Steps to Reproduce:
1. Go to Compute>Infra>VMs
2. Select a VM
3. Click on refresh Icon (not Browser refresh)

Actual results: UI moved one level up and shows all VMs


Expected results: VM is refreshed


Additional info:

Comment 2 Harpreet Kataria 2016-10-28 20:08:07 UTC
Dan,

Need to discuss this when you are back in office.

Issue here is that when clicking on reload button in explorers, it reloads the screen based on current selected/active node in the tree on left, if VMs are hidden from explorer tree clicking on reload button reloads the currently selected node in tree which is parent node of the VM that's being viewed. 

~Harpreet

Comment 3 Harpreet Kataria 2016-10-28 20:08:12 UTC
*** Bug 1389737 has been marked as a duplicate of this bug. ***

Comment 5 Harpreet Kataria 2016-11-04 21:14:20 UTC
Zita,

This issue is caused by not having VMs in the tree, when reload button is pressed in VM explorer, reload method does a tree_select and reloads the active node in the tree, i think we need to overwrite this method for VM explorers and if VMs are hidden in the tree we should reload the VM summary screen instead of a selected VMs parent node. Let me know if you want to discuss.

Thanks,
~Harpreet

Comment 6 Harpreet Kataria 2016-11-04 21:17:01 UTC
*** Bug 1390157 has been marked as a duplicate of this bug. ***

Comment 7 Harpreet Kataria 2016-11-07 15:58:32 UTC
*** Bug 1392139 has been marked as a duplicate of this bug. ***

Comment 8 Zita Nemeckova 2016-11-08 15:35:09 UTC
https://github.com/ManageIQ/manageiq/pull/12504

Comment 9 Mike Shriver 2016-11-15 13:59:24 UTC
Note that the same behavior is observed on the Clouds Instances Details pages.

When viewing details for a single instance, if the refresh button is clicked the application redirects to the Instances page, filtered by availability zone.

Comment 10 Zita Nemeckova 2016-11-15 15:04:54 UTC
I did. So my fix should work on Instances and Images as well :)

Comment 11 CFME Bot 2016-11-15 15:11:04 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/686573b04f138aec01c3f0a414280ea29270a9ed

commit 686573b04f138aec01c3f0a414280ea29270a9ed
Author:     Dan Clarizio <dclarizi>
AuthorDate: Mon Nov 14 12:52:00 2016 -0800
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Tue Nov 15 10:03:38 2016 -0500

    Merge pull request #12504 from ZitaNemeckova/vms_refresh_bug
    
    Fix refresh when VMs are hidden
    (cherry picked from commit 4a79904d75a30476932572f0baf134de3abcf04b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1389299

 app/controllers/mixins/vm_show_mixin.rb |  2 +-
 app/controllers/vm_common.rb            | 15 ++++++++++++++-
 spec/controllers/vm_common_spec.rb      | 25 +++++++++++++++++++++++++
 3 files changed, 40 insertions(+), 2 deletions(-)

Comment 13 Leo Khomenko 2017-02-06 17:11:11 UTC
verified on 5.7.1.0 (was fixed in latest 5.7.0.*)