Bug 1389346

Summary:	Review Request: python-testfixtures - A collection of helpers and mock objects for unit tests and doc tests
Product:	[Fedora] Fedora	Reporter:	David Hannequin <david.hannequin>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	besser82, package-review, zbyszek
Target Milestone:	---	Flags:	besser82: fedora-review-
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-06-18 21:54:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Hannequin 2016-10-27 13:22:22 UTC

Spec URL: https://hvad.fedorapeople.org/fedora/python-testfixtures/python-testfixtures.spec
SRPM URL: https://hvad.fedorapeople.org/fedora/python-testfixtures/python-testfixtures-4.10.1-1.fc24.src.rpm

Description: TestFixtures is a collection of helpers and mock objects that are
useful when writing unit tests or doc tests.If you're wondering why "yet
another mock object library", testing is often described as an art form and as
such some styles of library will suit some people while others will suit other
styles. This library contains common test fixtures the author found himself
repeating ...

Fedora Account System Username: hvad

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-11-12 18:36:35 UTC

%description should not be indented.

Also, it's not necessary to repeat the description text. See https://bugzilla.redhat.com/show_bug.cgi?id=879740#c13.

Also, it's not necessary to repeat the Summary. Use %{summary} in the second and subsequent ones.

.egg-info doesn't have to be deleted. The guidelines say that "binary eggs" have to be deleted, but that's not it.

Package is almost OK, but please fix those cosmetic issues.

Comment 2 David Hannequin 2016-11-21 12:57:35 UTC

Hi,

I fix description and summary with %_description and %{summary}. 

Is what I need to delete .egg-info ?

Best regard

Comment 3 Zbigniew Jędrzejewski-Szmek 2016-11-21 13:56:06 UTC

(In reply to David Hannequin from comment #2)
> Is what I need to delete .egg-info ?

There's no need to delete it in .spec. If you do delete it, it's not a big deal, but it's unnecessary.

Comment 4 David Hannequin 2016-12-28 20:20:49 UTC

Hi,

Spec URL: https://hvad.fedorapeople.org/fedora/python-testfixtures/python-testfixtures.spec
SRPM URL: https://hvad.fedorapeople.org/fedora/python-testfixtures/python-testfixtures-4.10.1-1.fc25.src.rpm

Can you review again ? 

Thanks

Comment 5 Zbigniew Jędrzejewski-Szmek 2017-03-05 22:20:39 UTC

Ooops, sorry, I missed that. An occasional ping or even NEEDINFO button often helps in such cases. 

There's really no need to delete .egg-info.

+ package name is OK
+ license is OK (MIT)
+ license is specified correctly
+ modern python packaging template is used
+ %python_provide is used
+ builds and installs OK
+ dependencies appear correct

Package is APPROVED.

Comment 6 David Hannequin 2017-06-18 16:29:03 UTC

What do you do with this package ? Why open an other bug 1445824 ?

Comment 7 Björn Esser (besser82) 2017-06-18 21:54:21 UTC

(In reply to David Hannequin from comment #6)
> What do you do with this package ? Why open an other bug 1445824 ?

This package is already present in Fedora;  my request for review was handled faster.

*** This bug has been marked as a duplicate of bug 1445824 ***