Bug 1389458

Summary:	No notifications on overview for deployment configs that don't have a service
Product:	OKD	Reporter:	Samuel Padgett <spadgett>
Component:	Management Console	Assignee:	Samuel Padgett <spadgett>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Yadan Pei <yapei>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.x	CC:	aos-bugs, jforrest, mmccomas, xxia, yanpzhan, yapei
Target Milestone:	---
Target Release:	3.x
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1384419	Environment:
Last Closed:	2017-05-30 12:48:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1384419
Bug Blocks:

Description Samuel Padgett 2016-10-27 15:37:53 UTC

See https://bugzilla.redhat.com/show_bug.cgi?id=1384419#c6

The alert is not showing up because we don't support notifications for unserviced deployment configs. Opening a separate bug to track.


+++ This bug was initially created as a clone of Bug #1384419 +++

Description of problem:
Deploy a dc several times, and cancel the last deployment, check on overview page, it displays the previous active deployment, but the latest deployment is not shown.


Version-Release number of selected component (if applicable):
openshift v1.4.0-alpha.0+c728fe9 (latest origin-web-console, latest commit is 03b49b4, manually vendored)
kubernetes v1.4.0+776c994
etcd 3.1.0-alpha.1


How reproducible:
Always

Steps to Reproduce:
1.Deploy a dc several times, and cancel the last deployment
2.Check dc/deployments on overview page
3.

Actual results:
2.it displays the previous active deployment, but the latest deployment is not shown

Expected results:
2.The latest deployment should be shown on overview page.

Additional info:

--- Additional comment from Samuel Padgett on 2016-10-13 09:22:50 EDT ---

I think it should just be an alert: "(!) Deployment #7 was cancelled."

--- Additional comment from Samuel Padgett on 2016-10-13 10:17:15 EDT ---

Note that this is working as intended, although it is a change from 1.2.

--- Additional comment from Yanping Zhang on 2016-10-13 22:17:51 EDT ---

(In reply to Samuel Padgett from comment #1)
> I think it should just be an alert: "(!) Deployment #7 was cancelled."

Yes, if possible, an alert would be better.

--- Additional comment from Samuel Padgett on 2016-10-25 10:33:42 EDT ---

https://github.com/openshift/origin-web-console/pull/722

--- Additional comment from Xingxing Xia on 2016-10-27 02:12:33 EDT ---

Tested against openshift v3.4.0.16+cc70b72, the PR is merged in.
Now it shows alert about the last cancelled/failed deployment (previous cancelled/failed deployment is replaced by the last). Looks good!

--- Additional comment from Xingxing Xia on 2016-10-27 03:13:52 EDT ---

Hmm, the fix works for DC that has linked service, but for DC that has no service, there is no alert for its last cancelled/failed deployment.
DC that has linked service:
$ oc new-app centos/ruby-22-centos7~https://github.com/openshift/ruby-ex.git

DC that has no service:
$ oc run hello --image=openshift/hello-openshift

--- Additional comment from Samuel Padgett on 2016-10-27 08:11:36 EDT ---

@Jessica, thoughts on this? It looks like we don't support any notifications for unserviced deployment configs.

Comment 1 Jessica Forrester 2016-11-02 13:24:25 UTC

This isn't a regression and we intentionally only supported notifications on things that had services before.  The change is big enough we should handle this underneath https://trello.com/c/QxbqJsoK

Comment 2 Jessica Forrester 2017-01-20 15:38:34 UTC

The overview story is delayed so marking UpcomingRelease

Comment 3 Samuel Padgett 2017-03-09 22:08:16 UTC

This will be fixed in the new overview.

https://github.com/openshift/origin-web-console/pull/1335

Comment 4 Yanping Zhang 2017-03-20 03:01:39 UTC

Checked against openshift v1.5.0-alpha.3+9be07d7-397.
Steps to verified:
1.Create dc without service:
$ oc run hello --image=openshift/hello-openshift
2.After the first deploy complete, deploy again, then cancel the deploy.check the dc on overview page, toggle the dc, there is notification:"Deployment hello #2 was cancelled."

The bug has been fixed, so move it to Verified.