Bug 1389649

Summary: [3.4] [quick install]Installation summary is not correct when specifying a dedicated etcd in installer.cfg.yml
Product: OpenShift Container Platform Reporter: liujia <jiajliu>
Component: InstallerAssignee: Samuel Munilla <smunilla>
Status: CLOSED ERRATA QA Contact: liujia <jiajliu>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.4.0CC: aos-bugs, jokerman, mmccomas, smunilla
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: The installation summary was only printing etcd hosts if they were also masters. Consequence: Dedicated etcd hosts were not appearing in the installation summary. Fix: Removed the check for masters prior to the check for etcd hosts. Result: Installation Summary is now correct.
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-01-31 21:10:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description liujia 2016-10-28 06:01:00 UTC
Description of problem:
Edit installer.cfg.yml to have a dedicated etcd host, and then trigger an install/scaleup, the installation summary output is not correct.
*** Installation Summary ***

Hosts:
- openshift-118.x.x.x
  - OpenShift master
  - OpenShift node (Unscheduled)
  - Etcd (Embedded) //should not be etcd
  - Storage
- openshift-136.x.x.x
  - OpenShift node (Dedicated)
- openshift-116.lab.eng.nay.redhat.com  //should be etcd role

Total OpenShift masters: 1
Total OpenShift nodes: 2


Version-Release number of selected component (if applicable):
atomic-openshift-utils-3.4.13-1.git.0.ff1d588.el7.noarch


How reproducible:
always

Steps to Reproduce:
1.Edit installer.cfg.yml
#cat /root/.config/openshift/installer.cfg.yml
<--snip-->
deployment:
  ansible_ssh_user: root
  hosts:
  - connect_to: openshift-x.x.x
    hostname: 192.168.2.4
    ip: 192.168.2.4
    public_hostname: 10.66.147.118
    public_ip: 10.66.147.118
    roles:
    - master
    - node
    - storage
  - connect_to: openshift-x.x.x
    hostname: 192.168.2.53
    ip: 192.168.2.53
    node_labels: '{''region'': ''infra''}'
    public_hostname: 10.66.147.136
    public_ip: 10.66.147.136
    roles:
    - node
  - connect_to: openshift-x.x.x
    hostname: 192.168.2.46
    ip: 192.168.2.46
    public_hostname: 10.66.147.116
    public_ip: 10.66.147.116
    roles:
    - etcd

2.trigger an install
# atomic-openshift-installer -c /root/.config/openshift/installer.cfg.yml install


Actual results:
*** Installation Summary ***

Hosts:
- openshift-118.x.x.x
  - OpenShift master
  - OpenShift node (Unscheduled)
  - Etcd (Embedded) //should not be etcd
  - Storage
- openshift-136.x.x.x
  - OpenShift node (Dedicated)
- openshift-116.lab.eng.nay.redhat.com  //should be etcd role

Total OpenShift masters: 1
Total OpenShift nodes: 2

Expected results:
The printed summary should be consistent with installer.cfg.yml.

Comment 3 liujia 2017-01-09 09:40:43 UTC
Version:
openshift-ansible-roles-3.4.43-1.git.0.a9dbe87.el7.noarch

Steps:
1.Edit installer.cfg.yml
# cat installer.cfg.yml
<--snip-->
deployment:
  ansible_ssh_user: root
  hosts:
  - connect_to: openshift-109.x.x.x
    hostname: openshift-109.x.x.x
    ip: 192.168.2.141
    node_labels: '{''region'': ''infra''}'
    public_hostname: openshift-109.x.x.x
    public_ip: 10.66.147.109
    roles:
    - master
    - node
    - storage
  - connect_to: openshift-129.x.x.x
    hostname: openshift-129.x.x.x
    ip: 192.168.2.140
    public_hostname: openshift-129.x.x.x
    public_ip: 10.66.147.129
    roles:
    - etcd

2.trigger an install
# atomic-openshift-installer -c /root/work/inventory/test/installer.cfg.yml install/scaleup

Result:
*** Installation Summary ***

Hosts:
- openshift-109.x.x.x
  - OpenShift master
  - OpenShift node
  - Storage
- openshift-129.x.x.x
  - Etcd

Total OpenShift masters: 1
Total OpenShift nodes: 1


The printed summary is consistent with installer.cfg.yml. So changed the status to verified.

Comment 5 errata-xmlrpc 2017-01-31 21:10:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0224