Bug 1389667

Summary: [quick install]Can not detect new host when scaleup with a specified installer.cfg.yml
Product: OpenShift Container Platform Reporter: liujia <jiajliu>
Component: InstallerAssignee: Scott Dodson <sdodson>
Status: CLOSED WONTFIX QA Contact: Wenkai Shi <weshi>
Severity: low Docs Contact:
Priority: low    
Version: 3.4.0CC: aos-bugs, jokerman, mmccomas, mnozell, smunilla
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-25 15:51:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description liujia 2016-10-28 07:52:38 UTC
Description of problem:
Trigger an scaleup and input new node hostname. When it comes to ensure facts, input 'N' to exit from the interaction due to the gathered hostname for the new node is not correct, then edit installer.cfg.yml to update the new added node info. But after that, when run scaleup again with '-c', it can not detect this fresh node and still ask user to input new node info again. 

Version-Release number of selected component (if applicable):
atomic-openshift-utils-3.4.13-1.git.0.ff1d588.el7.noarch


How reproducible:
always

Steps to Reproduce:
1.Trigger an scaleup
# atomic-openshift-installer scaleup

2.Edit installer.cfg.yml to add an label for the new node.
#cat /root/.config/openshift/installer.cfg.yml
<--snip-->
deployment:
  ansible_ssh_user: root
  hosts:
 ....
  - connect_to: openshift-139.x.x.x
    hostname: 192.168.2.186
    ip: 192.168.2.186
    node_labels: '{''region'': ''infra''}'
    public_hostname: 10.66.147.139
    public_ip: 10.66.147.139
    roles:
    - node
<--snip-->

3.Run scaleup again
# atomic-openshift-installer -c /root/.config/openshift/installer.cfg.yml scaleup

Actual results:
It will print installation summary and then go to the workflow "New Node Configuration" and ask user to input new node's info again.It seems that it does not detect which hosts are installed and which hosts are fresh. It will result that user can not edit info in installer.cfg.yml when scaleup.

Expected results:
It will detected fresh hosts and pass "New Node Configuration" step to go to left steps for scaleup.

Comment 1 liujia 2016-12-02 10:47:20 UTC
Scaleup with "--gen-inventory" hint the same problems which result that inventory file will not be generated for scaleup.

Comment 2 liujia 2016-12-05 05:48:18 UTC
For latest test, QE met a problem that after "Gathering information from hosts..." when added a node to existed cluster, it would get wrong "hostname" and "public hostname", which results that user have to edit installer.cfg.yml to run "atomic-openshift-installer scaleup" again.

But due to this bug, it can not go on scaleup with quick installer. I think it is better to fix it before release, so change the priority to "high".