Bug 1389668

Summary:	Jenkins Poll SCM log does update when change pipeline script
Product:	OKD	Reporter:	shiyang.wang <shiywang>
Component:	Image	Assignee:	Gabe Montero <gmontero>
Status:	CLOSED WONTFIX	QA Contact:	Wang Haoran <haowang>
Severity:	low	Docs Contact:
Priority:	low
Version:	3.x	CC:	aos-bugs, bparees, cewong, mmccomas
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-07 20:30:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description shiyang.wang 2016-10-28 07:53:38 UTC

Description of problem:
when testing jenkins images, login to the jenkins webconsole, trigger a Poll SCM job with pipeline script, after first build, change the pipline script and save the configuare, Poll SCM log output still using old pipeline script.

Version-Release number of selected component (if applicable):


docker.io/openshift/jenkins-1-centos7
oc v3.4.0.16+cc70b72
kubernetes v1.4.0+776c994
openshift v3.4.0.16+cc70b72


How reproducible:
Always

Steps to Reproduce:
1. oc new-app -f https://raw.githubusercontent.com/openshift/origin/master/examples/jenkins/jenkins-ephemeral-template.json

2. Go to jenkins job page click "new item" -->write item name: openshifttest-->select "Pipeline"-->save

Select pipelinejob "openshifttest" to Configure

  select tab "Build Triggers" => click "Poll SCM"

  input a time for cron job like: "H/3 * * * *"  

  select "Pipeline script from SCM"

Set the Script Path to  this Jenkinsfile

node{

  stage 'ImageStreams SCM'

  openshiftImageStream( name: "nodejs-helloworld-sample", tag: "latest", namespace: "test" )

  echo "hello world"

}
3.Click "Save"

4.After first build, change pipeline script, eg: change namespace: "test"  to "test1"

5.Click "Save" and check SCM Poll log for a while 

Actual results:

Poll SCM log output still use namespace"test"

Expected results:

Poll SCM log output should use namespace"test1"

Additional info:

Comment 1 Cesar Wong 2016-10-31 12:14:15 UTC

PR here https://github.com/openshift/jenkins-plugin/pull/100

Comment 2 Cesar Wong 2016-10-31 17:19:37 UTC

The PR mentioned above fixed an issue with the ImageStream SCM step where the namespace was not getting used. However, the issue that this bug describe still exists. It seems to be a problem with how the Jenkins pipeline plugin works. It relies on the data stored in the previous build to do SCM polling. I tried with a git SCM step and it behaves exactly the same.

Comment 3 Cesar Wong 2016-10-31 17:44:29 UTC

A related JIRA can be found here:
https://issues.jenkins-ci.org/browse/JENKINS-37626?jql=text%20~%20%22pipeline%20scm%22

Lowering the severity given that this relies on an external fix to the pipeline plugin.

Comment 4 Gabe Montero 2017-12-07 19:17:02 UTC

Actually, the use case in the description does not entirely line up with what I am seeing when I reproduce locally.

When you select "Pipeline script from SCM", you are provided our "mini" freestyl job type panel for configuring the images stream scm. Much the same way as when you click "Pipeline Syntax" and get the "Snippet Generator".

It is *THAT* scm which is used by the job. Not any openshiftImageStream SCM that you specify in the script path / Jenkinsfile, which is what I interpret being described in step 4.

Doing "Pipeline scrip from SCM" takes you down the CpsScmFlowDefiniation path (that's a java class in the workflow plugin) vs. the standard CpsScrip path (another class).

When I select the OpenShift Imagestream SCM from the SCM drop down for "Pipeline script from SCM", and then change its values like namespace, they are picked up.

That said, this "Pipieline script from SCM" form of pipeline is definitely flaky from the jenkins side. Aside from the Jira Cesar noted, I'm hitting some other weird stuff (including jenkins overriding the scm poller in certain cases).

But when I can change fields like the namespace, it works.

Also, the script ref field to the Jenkinsfile is tailored to "code" scm's like git or subversion, where the Jenkinsfile is in the repo to check out. There is not Jenkinsfile to point to here. The test must have manually stored a jenkins file off of the workspace.

Not a first class workflow, nor seems like something we should be worried about or enhance to make more first class.

Going to propose closing this bug out then. Aside from what I described above, including the workflow plugin flakiness above,

a) the image stream poller works without the use of "pipeline script from scm" ... see the ext tests that leverage https://github.com/openshift/origin/blob/master/test/extended/testdata/jenkins-plugin/imagestream-scm-dsl-job.xml

b) we have already marked openshift-pipeline-plugin in maintenance only mode ... deprecation is coming at some point

c) since we introduced the IS SCM poller, we introduced pipeline strategy ... you can define such a BC with an ICT, and start pipielines that way.

The only reason I did not close right now is I'm on the fence on how much of these gory details do we want to document in the jenkins-plugin README.

Thoughts Ben / Cesar ?

Comment 5 Gabe Montero 2017-12-07 20:30:34 UTC

OK, Ben and I talked, and walked through the various flows from the jenkins UI.  He agrees with what I implied in Comment #4 that this is too obscure of a scenario, as well as the fact that a Pipeline build strategy coupled with an image change trigger is the proscribed way of doing this moving forward.

Closing out.