Bug 1389679

Created attachment 1214865 [details]
/var/log; /tmp

Add keyword "regression" due to no such issue on previous iso (RHVH-4.0-20161007.0-RHVH-x86_64-dvd1.iso)

This seems to be a regression of 1380797.

From ks snippet log:

[INFO] Syncing systemd levels
rm: cannot remove '/tmp/mnt.mjju6///etc/systemd/system/multi-user.target.wants/chronyd.service': No such file or directory
[ERROR] Failed to migrate etc
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/osupdater.py", line 74, in on_new_layer
    migrate_etc(imgbase, new_lv, previous_layer_lv)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/osupdater.py", line 164, in migrate_etc
    fix_systemd_services(old_fs, new_fs)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/osupdater.py", line 196, in fix_systemd_services
    remove_file(new_fs.path("/") + d)
  File "/usr/lib/python2.7/site-packages/imgbased/utils.py", line 52, in remove_file
    return rm(args)
  File "/usr/lib/python2.7/site-packages/imgbased/utils.py", line 358, in rm
    return self.call(["rm"] + args, **kwargs)
  File "/usr/lib/python2.7/site-packages/imgbased/utils.py", line 323, in call
    stdout = call(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/imgbased/utils.py", line 117, in call
    return subprocess.check_output(*args, **kwargs).strip()
  File "/usr/lib64/python2.7/subprocess.py", line 575, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
CalledProcessError: Command '['rm', u'/tmp/mnt.mjju6///etc/systemd/system/multi-user.target.wants/chronyd.service']' returned non-zero exit status 1
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/lib/python2.7/site-packages/imgbased/__main__.py", line 51, in <module>
    CliApplication()
  File "/usr/lib/python2.7/site-packages/imgbased/__init__.py", line 82, in CliApplication
    app.hooks.emit("post-arg-parse", args)
  File "/usr/lib/python2.7/site-packages/imgbased/hooks.py", line 120, in emit
    cb(self.context, *args)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/core.py", line 163, in post_argparse
    layout.initialize(args.source, args.init_nvr)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/core.py", line 211, in initialize
    self.app.imgbase.init_layout_from(source, init_nvr)
  File "/usr/lib/python2.7/site-packages/imgbased/imgbase.py", line 244, in init_layout_from
    self.add_layer(initial_base, new_layer)
  File "/usr/lib/python2.7/site-packages/imgbased/imgbase.py", line 170, in add_layer
    self.hooks.emit("new-layer-added", prev_lv, new_lv)
  File "/usr/lib/python2.7/site-packages/imgbased/hooks.py", line 120, in emit
    cb(self.context, *args)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/osupdater.py", line 77, in on_new_layer
    raise ConfigMigrationError()
imgbased.plugins.osupdater.ConfigMigrationError

Is this a TestBlocker?

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

(In reply to Fabian Deutsch from comment #3)
> This seems to be a regression of 1380797.
> 
If so, the bug 1380797 is MODIFIED status and is targeted to ovirt-4.1.0, not sure why the patches affect z-stream?

Tested the upstream build ovirt-node-ng-installer-ovirt-4.0-snapshot-2016102804.iso, still failed with the same error like in comment 3. 

<snip>
rm: cannot remove '/tmp/mnt.ew9UH///etc/systemd/system/multi-user.target.wants/chronyd.service': No such file or directory
[ERROR] Failed to migrate etc
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/osupdater.py", line 74, in on_new_layer
    migrate_etc(imgbase, new_lv, previous_layer_lv)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/osupdater.py", line 164, in migrate_etc
    fix_systemd_services(old_fs, new_fs)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/osupdater.py", line 196, in fix_systemd_services
    remove_file(new_fs.path("/") + d)
  File "/usr/lib/python2.7/site-packages/imgbased/utils.py", line 52, in remove_file
    return rm(args)
  File "/usr/lib/python2.7/site-packages/imgbased/utils.py", line 358, in rm
    return self.call(["rm"] + args, **kwargs)
  File "/usr/lib/python2.7/site-packages/imgbased/utils.py", line 323, in call
    stdout = call(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/imgbased/utils.py", line 117, in call
    return subprocess.check_output(*args, **kwargs).strip()
  File "/usr/lib64/python2.7/subprocess.py", line 575, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
CalledProcessError: Command '['rm', u'/tmp/mnt.ew9UH///etc/systemd/system/multi-user.target.wants/chronyd.service']' returned non-zero exit status 1
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/lib/python2.7/site-packages/imgbased/__main__.py", line 51, in <module>
    CliApplication()
  File "/usr/lib/python2.7/site-packages/imgbased/__init__.py", line 82, in CliApplication
    app.hooks.emit("post-arg-parse", args)
  File "/usr/lib/python2.7/site-packages/imgbased/hooks.py", line 120, in emit
    cb(self.context, *args)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/core.py", line 163, in post_argparse
    layout.initialize(args.source, args.init_nvr)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/core.py", line 211, in initialize
    self.app.imgbase.init_layout_from(source, init_nvr)
  File "/usr/lib/python2.7/site-packages/imgbased/imgbase.py", line 244, in init_layout_from
    self.add_layer(initial_base, new_layer)
  File "/usr/lib/python2.7/site-packages/imgbased/imgbase.py", line 170, in add_layer
    self.hooks.emit("new-layer-added", prev_lv, new_lv)
  File "/usr/lib/python2.7/site-packages/imgbased/hooks.py", line 120, in emit
    cb(self.context, *args)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/osupdater.py", line 77, in on_new_layer
    raise ConfigMigrationError()
imgbased.plugins.osupdater.ConfigMigrationError

</snip>

In comment 3 I was actually referring to the zstream clone bug 1388317 - but did not point it out.

I'll revert the patch tof ix this issue.

I just learned that there is a way to work around the issue for SVVP testing, tuhs I will not revert the patch.

Test version:
redhat-virtualization-host-4.0-20161107.0
imgbased-0.8.7-0.1.el7ev.noarch

Test steps:
1. Anaconda interactive install RHVH via iso on local machine with default ks.
2. Anaconda interactive install RHVH via iso on UEFI machine with default ks.
3. Anaconda interactive install RHVH via iso on ISCSI machine with default ks.
4. Anaconda interactive install RHVH via iso on FC machine with default ks.
5. Try to finish the installation with correct steps.
6. Focus on the installation process.

Test results:
Anaconda interactive install RHVH can successful via ISO.

So the bug is fixed, change bug status to VERIFIED.

I have this exact error on 3 production dell servers with:

ovirt-node-ng-installer-ovirt-4.1-2017110715.iso

from jenkins.