Bug 1389685

Summary: [userinterface_public_691] Should support empty input of destinationDir on BC editor page
Product: OpenShift Container Platform Reporter: Xingxing Xia <xxia>
Component: Management ConsoleAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED CURRENTRELEASE QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.4.0CC: aos-bugs, jokerman, mmccomas
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Adding a Build Secret in the BC editor page without destinationDir or mountPath. Consequence: Cant save the updated BC since destinationDir/mountPoint are required fields Fix: Remove the `require` attribute on the destinationDir/mountPoint input field Result: User can add Build Secret without destinationDir/mountPoint and save it.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-08 18:36:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Xingxing Xia 2016-10-28 09:02:03 UTC 
Description of problem:
Should support empty input of destinationDir on BC editor page.
See https://docs.openshift.org/latest/dev_guide/builds.html#using-secrets-s2i-strategy which says "If you left destinationDir empty, then the secrets are placed in the working directory of the builder image". This means it should be supported.


Version-Release number of selected component (if applicable):
openshift v3.4.0.16

How reproducible:
Always

Steps to Reproduce:
1. Create a BC, prepare secrets
$ oc new-build centos/ruby-22-centos7~https://github.com/openshift/ruby-ex.git
$ oc secrets new-basicauth gitsecret --username=user --password=12345678
$ touch file; oc secrets new mysecret file

2. Login to web openshift console, go to BC ruby-ex editor page: https://<master>:8443/console/project/xxia-test/edit/builds/ruby-ex
Click "advanced options",
1> under the "Build Secret" part, click the box, select a secret, input "/tmp" in "Destination Directory".
2> check the "Add another secret" and "Save" button

3. As comparison, click "Add another secret", in the new input,
1> select a secret, but leave "Destination Directory" empty
2> check the "Add another secret" and "Save" button again

Actual results:
2.
2> After input in "Destination Directory", it enables the "Add another secret" and "Save" button (blue color)

3.
2> When leave "Destination Directory" empty, the "Add another secret" is not shown, "Save" button is gray

Expected results:
3.
2> Should support empty input of destinationDir. When leave "Destination Directory" empty, the "Add another secret" should be shown, "Save" button should be enabled.

Additional info:
Comment 1 openshift-github-bot 2016-10-31 14:45:59 UTC 
Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/ffe2129fc0f9de2c76da7c03b701ef8c3cdf6418
Bug 1389685 - Support empty input of destinationDir on BC editor page
Comment 2 Xingxing Xia 2016-11-02 04:42:01 UTC 
In latest puddle, openshift version 3.4.0.18 has not yet included the PR. Wait for next puddle.
Comment 3 Yadan Pei 2016-11-03 07:45:02 UTC 
Checked against v3.4.0.19+346a31d


When leave Destination Directory empty in "Build Secrets" part, "Add another  secret" and "Save" button is enabled, and empty destination directory could be saved successfully

move to VERIFIED