Bug 1389734

Summary: Two "Attach storage" links show up on dc page
Product: OpenShift Container Platform Reporter: Yanping Zhang <yanpzhan>
Component: Management ConsoleAssignee: Jessica Forrester <jforrest>
Status: CLOSED CURRENTRELEASE QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.4.0CC: aos-bugs, jforrest, jokerman, mmccomas, pweil, tdawson, wehe
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-12 14:39:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
dup.png
none
2links-on-rc
none
newscreenshot none

Description Yanping Zhang 2016-10-28 11:10:23 UTC
Created attachment 1214972 [details]
dup.png

Description of problem:
Create dc in project, check on dc page, there are two "Attach storage" link on the page, they are duplicated.

Version-Release number of selected component (if applicable):
openshift v3.4.0.16

How reproducible:
Always

Steps to Reproduce:
1.Create dc in project, check on dc page.
2.
3.

Actual results:
1.There are two "Attach storage" link on the page, they are duplicated. Refer to attachment.

Expected results:
2.Should only keep one "Attach storage" link on the page.

Additional info:

Comment 1 Yanping Zhang 2016-10-28 11:45:24 UTC
The issue seems happen on those dc: created by oc run, or created from web by deploying image.

Comment 2 Zac Herman 2016-10-31 17:53:43 UTC
PR #770 open to resolve this issue

Comment 3 openshift-github-bot 2016-10-31 18:23:33 UTC
Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/d4becd8aedc3f39efdb1272a1cd66ff1212c9e7c
Merge pull request #770 from zherman0/bug1389734

Merged by openshift-bot

Comment 4 Troy Dawson 2016-11-02 17:46:30 UTC
This has been merged into ose and is in OSE v3.4.0.19 or newer.

Comment 6 Yanping Zhang 2016-11-03 03:07:08 UTC
Checked on OCP v3.4.0.19, create dc by different methods, by creating app from image, by oc run and by deploying image, check on those dc page and rc page, now "Attach storage" shows one time correctly.
The bug is fixed, so move it to Verified.

Comment 7 Yanping Zhang 2016-11-03 08:20:05 UTC
Sorry, I found that there are still two "Add storage" link under "Action" button on rc page. It's curious that I didn't see two "Add storage" link there in my first check, but I saw them in my second check after some time. Pls refer to the attachment.

Comment 8 Yanping Zhang 2016-11-03 08:21:50 UTC
Created attachment 1216883 [details]
2links-on-rc

Comment 9 Zac Herman 2016-11-04 16:56:08 UTC
Can you please re-test this.  I see the wording is different in your image than what the current build has.  I think the issues are all resolved now.  BTW, it now reads "Add Storage" instead of "Attach Storage"

Comment 10 Yanping Zhang 2016-11-07 03:52:15 UTC
openshift v3.4.0.22+5c56720
kubernetes v1.4.0+776c994
etcd 3.1.0-rc.0
I tested on above OCP env again, still can reproduce the issue in Comment 7. The issue doesn't show up when the rc is just created, we can see two "Add Storage" in "Actions" list on rc page after wait for about 20 minutes. Attach a new screenshot. Pls check, thanks!

Comment 11 Yanping Zhang 2016-11-07 03:53:38 UTC
Created attachment 1217851 [details]
newscreenshot

Comment 12 Jessica Forrester 2016-11-08 12:50:49 UTC
I see whats wrong in the source, I'll take this

Comment 13 Jessica Forrester 2016-11-08 14:41:23 UTC
We think this should be fixed in https://github.com/openshift/origin-web-console/pull/847

Comment 14 Troy Dawson 2016-11-09 19:44:39 UTC
This has been merged into ose and is in OSE v3.4.0.24 or newer.

Comment 15 Yanping Zhang 2016-11-10 07:16:23 UTC
Checked on OCP v3.4.0.24, the "Add Storage" link show one time under "Actions" list on rc page now. The bug has been fixed, so move it to Verified.