Bug 1389776

Summary: all azure events appear as is in timelines
Product: Red Hat CloudForms Management Engine Reporter: Ievgen Zapolskyi <izapolsk>
Component: ProvidersAssignee: Bronagh Sorota <bsorota>
Status: CLOSED NOTABUG QA Contact: Ievgen Zapolskyi <izapolsk>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.6.0CC: dajohnso, izapolsk, jfrey, jhardy, obarenbo
Target Milestone: GA   
Target Release: cfme-future   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ui:timelines, provider:azure:general:usability
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-18 12:47:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Azure Target Upstream Version:

Description Ievgen Zapolskyi 2016-10-28 15:00:09 UTC 
Description of problem:
Every action in Azure emits two/several events. 
So, every action has two/several events in Timelines as result.
The usability of such events in timelines is low. Actually, those just clog timelines.

It would be better to combine them and show real action and its status, etc. 

Version-Release number of selected component (if applicable):
CFME 5.6.2.2

How reproducible:
100%

Steps to Reproduce:
1. Add Azure provider to CFME 
2. f.e. Create/Start/Stop/Remove some Vm in Azure
3. Open Timelines for VM or Provider 

Actual results:
Every operation will have at least 2 events in Timelines.


Expected results:
To combine events related to one operation and display the operation and its
params correctly in Timelines.


Additional info:
Comment 2 Greg Blomquist 2016-11-02 22:27:17 UTC 
*** Bug 1390582 has been marked as a duplicate of this bug. ***
Comment 4 Bronagh Sorota 2016-11-04 16:41:57 UTC 
Levgen

If I am understanding your request correctly, you would like the correlated begin and end events to be combined into 1 single event.
If you're using events to drive automation you may want to do different things at the beginning versus the end. For example, you may want to check and apply policy before a migration, so you can prevent the migration if it isn't allowed. This would no longer be possible if the begin and end events are combined.

One thing you can do is to add a specific event to the blacklisted_events table in the DB. This means that event will be filtered out when CF receives it. 

BlacklistedEvent.create(:event_name=>"testabc", :provider_model => ems.type, :enabled => true)

I believe this is not an Azure specific issue, many of the providers send both begin and end events.

John,
have you received any complaints around this before? Any plans in this area?

Thanks,
Bronagh
Comment 5 Ievgen Zapolskyi 2016-11-07 13:32:59 UTC 
Bronagh,

Actually, I haven't seen any other provider sending both begin and end events.
However, I agree the case you have mentioned makes sense and I don't want to reduce existing functionality.

Frankly speaking, I experience this issue only in timelines.
So, I guess it makes sense to combine such events only in timelines.
Comment 6 Bronagh Sorota 2016-11-08 16:14:24 UTC 
levgen
If you look at the :event_groups section of the file: https://github.com/ManageIQ/manageiq/blob/master/config/settings.yml
you will see some similar pairings eg:
      - USER_ADD_VM
      - USER_ADD_VM_FINISHED_FAILURE
      - USER_ADD_VM_FINISHED_SUCCESS


VMware always has a Complete event:
     - CloneVM_Task
      - CloneVM_Task_Complete
      - CreateClusterEx
      - CreateClusterEx_Complete

Are these treated the same as the Azure events? 
How are the reports impacted?
Comment 7 Ievgen Zapolskyi 2016-11-18 12:47:29 UTC 
only certain events appear in Timelines. F.e CloneVm_Task event doesn't appear there.

Timelines look much better in 5.7 due to grouping events and so on.
So, I'm about to close this ticket for now