Bug 1389781

Summary:	build: python on Debian-based dists use .../lib/python2.7/dist-packages instead of .../site-packages
Product:	[Community] GlusterFS	Reporter:	Kaleb KEITHLEY <kkeithle>
Component:	build	Assignee:	Kaleb KEITHLEY <kkeithle>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8	CC:	bugs, ndevos
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1389740	Environment:
Last Closed:	2017-01-16 12:26:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1388861, 1389740
Bug Blocks:	1350744

Description Kaleb KEITHLEY 2016-10-28 15:09:38 UTC

+++ This bug was initially created as a clone of Bug #1389740 +++

+++ This bug was initially created as a clone of Bug #1388861 +++

Description of problem:

configure(.ac) doesn't correctly get the location for the gluster and glupy python packages.

It turns out that the python pkgconfig bits for python has already figured it out correctly.

Version-Release number of selected component (if applicable):


How reproducible:

build and install on Debian. Observe that the python __init__.py files are installed in /usr/lib/python2.7/site-packages/... instead of /usr/lib/python2.7/dist-packages.


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-10-26 09:23:09 EDT ---

REVIEW: http://review.gluster.org/15733 (build: python site-packages vs. dist-packages) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

--- Additional comment from Worker Ant on 2016-10-28 08:22:04 EDT ---

REVIEW: http://review.gluster.org/15752 (build: python site-packages vs. dist-packages) posted (#1) for review on release-3.9 by Kaleb KEITHLEY (kkeithle)

Comment 1 Worker Ant 2016-10-28 15:16:58 UTC

REVIEW: http://review.gluster.org/15755 (build: python site-packages vs. dist-packages) posted (#1) for review on release-3.8 by Kaleb KEITHLEY (kkeithle)

Comment 2 Worker Ant 2016-12-14 07:01:39 UTC

COMMIT: http://review.gluster.org/15755 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit a2ef53dd6946a8fb407e15228eeb4d86de906d28
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Fri Oct 28 11:15:27 2016 -0400

    build: python site-packages vs. dist-packages
    
    Unlike Fedora and RHEL/CentOS, where python has
    /usr/{lib,lib64}/python2.7/site-packages/..., Debian-based
    distributions have /usr/lib/python2.7/dist-packages/...
    
    On Debian our python scriptlet to determine this is broken and
    incorrectly returns .../site-packages, not .../dist-packages.
    Furthermore, the automake/autoconf/pkgconfig bits ahead of our
    own scriptlet have already determined the correct location -- all
    we need to do is use it.
    
    This change also slightly reworks the BUILD_PYTHON_INC scriptlet
    to bring it in line with the style/pattern of the other python
    scriptlets provided by autoconf/pkgconfig.
    
    (I do wonder though, why we have two sets of {C,CPP}FLAGS and
    LD_FLAGS - PYTHONDEV_CPPFLAGS and BUILD_PYTHON_INC, and
    PYTHONDEV_LDFLAGS and BUILD_PYTHON_LIB.
    
    They both have very similar values, but, e.g. BUILD_PYTHON_INC
    misses /usr/lib/x86_64-linux-gnu/python2.7 on Debian; even if
    that ommission doesn't seem to be hurting us.)
    
    Change-Id: I309a5c781a1d9aee4d7be2867223781bd2ae18fa
    BUG: 1389781
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/15755
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Worker Ant 2016-12-21 23:22:01 UTC

REVIEW: http://review.gluster.org/16256 (build: python site-packages vs. dist-packages) posted (#1) for review on release-3.8-fb by Kevin Vigor (kvigor)

Comment 4 Niels de Vos 2017-01-16 12:26:06 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.8, please open a new bug report.

glusterfs-3.8.8 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2017-January/000064.html
[2] https://www.gluster.org/pipermail/gluster-users/