Bug 1389820

Summary: [RFE] Find feature for provisioning template editing
Product: Red Hat Satellite Reporter: jpisciot
Component: Provisioning TemplatesAssignee: Sebastian Gräßl <sgraessl>
Status: CLOSED ERRATA QA Contact: Ondrej Gajdusek <ogajduse>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.2.2CC: apitanga, avroy, bkearney, bmidwood, ehelms, kupadhya, mhulan, tstrachota
Target Milestone: 6.4.0Keywords: FutureFeature, Reopened, Triaged
Target Release: Unused   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-06-14 07:50:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screen shot of search box none

Description jpisciot 2016-10-28 18:40:12 UTC
Proposed title of this feature request  

Find
      
Who is the customer behind the request?  

UBS
      
What is the nature and description of the request?  

Foreman provisioning profiles text editor should have a find option. The web browser find does not work to search the code area.

Why does the customer need this? (List the business requirements here)  

 A search enabled text editor is very desirable for clients that heavily use provisioning templates to customize builds.

Comment 1 Tomas Strachota 2017-08-13 21:16:11 UTC
Created redmine issue http://projects.theforeman.org/issues/20573 from this bug

Comment 2 Tomas Strachota 2017-08-13 21:18:24 UTC
Reproducer steps:
- open a detail page of a provisioning template
- click on the editor textarea (to make sure it gets focus)
- press Ctrl+F

Current results:
Nothing happens.

Expected results:
It should open a searchbox within the template editor.


Note that as a workaround you can currently click somewhere outside of the textarea and press Ctrl+F afterwards, which should trigger the default browser search.

Comment 3 Satellite Program 2017-08-21 12:07:20 UTC
Upstream bug assigned to sgraessl

Comment 4 Satellite Program 2017-08-21 12:07:24 UTC
Upstream bug assigned to sgraessl

Comment 5 Satellite Program 2017-08-22 12:07:15 UTC
Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/20573 has been resolved.

Comment 6 Perry Gagne 2018-08-01 19:34:51 UTC
Verified fix in sat 6.4 snap 15. When your click into the text box and press Ctrl-F (of Cmd-F on Mac) it brings up ACE editors integrated search function. See attached screen shot

Comment 7 Perry Gagne 2018-08-01 19:35:28 UTC
Created attachment 1472196 [details]
screen shot of search box

Comment 9 errata-xmlrpc 2018-10-16 15:26:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2927

Comment 11 Bryan Kearney 2020-12-03 04:02:59 UTC
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/20573 has been resolved.

Comment 13 Marek Hulan 2021-05-27 09:07:34 UTC
While this was working for a while, it got broken later, probably during the editor conversion to react. I believe this is a must for people who are tweaking provisioning, report and job templates. Currently the workaround is to get the focus outside of the editor (click on the white background) and use ctrl+f which sues browser native searching. However that's suboptimal, when the text in the editor requires scrolling. I'd recommend closing this but opening a regression bug instead. This was an existing feature once. Avroy, can you please open such bug and link it here?

Comment 15 Marek Hulan 2021-06-14 07:50:53 UTC
Thanks, closing this for now, it's tracked under under https://bugzilla.redhat.com/show_bug.cgi?id=1971072

Comment 16 Red Hat Bugzilla 2023-09-15 00:00:26 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days