Bug 1390271
| Summary: | in few of ui dialogs the fields position is pushed down or cut after replacing to the new list boxes | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Sharon Gratch <sgratch> | ||||||||||||||||
| Component: | Frontend.WebAdmin | Assignee: | Alexander Wels <awels> | ||||||||||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Pavel Novotny <pnovotny> | ||||||||||||||||
| Severity: | medium | Docs Contact: | |||||||||||||||||
| Priority: | unspecified | ||||||||||||||||||
| Version: | 4.1.0 | CC: | bugs, oourfali, sgratch, ylavi | ||||||||||||||||
| Target Milestone: | ovirt-4.1.2 | Flags: | rule-engine:
ovirt-4.1+
rule-engine: planning_ack+ oourfali: devel_ack+ pstehlik: testing_ack+ |
||||||||||||||||
| Target Release: | 4.1.2 | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Whiteboard: | |||||||||||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||
| Last Closed: | 2017-05-23 08:18:08 UTC | Type: | Bug | ||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||
| oVirt Team: | UX | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||
| Embargoed: | |||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
Created attachment 1215852 [details]
screenshot
Created attachment 1215853 [details]
screenshot
Created attachment 1215854 [details]
screeenshot
We have switched only in 4.1, not in 4.0.5. Are you sure you're working with 4.0.5? (In reply to Oved Ourfali from comment #4) > We have switched only in 4.1, not in 4.0.5. > Are you sure you're working with 4.0.5? you are right, it was tested on 4.1 (master). My mistake, sorry. This is technically 2 bugs in one, one for the network interface layout and one for the image import layout. I will make 2 separate patches one for each issue. The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified. FailedQA in ovirt-engine-webadmin-portal-4.1.0.3-0.1.el7.noarch rhevm-4.1.0.3-0.1.el7.noarch The trimmed input boxes and labels have been fixed, however the fix affected another parts of the layout: 1) VM network interface dialog Spacing between the "Custom MAC address" text input and "Example: 00:14..." text is now too big so it seems that the hint text belongs to the "Up" icon below it. The "Unplugged" icon at the bottom overlaps the dialog content border. This applies only for upcoming Firefox 52b2 ESR (51 is also affected). In Firefox 45 ESR and Chromium 55 it is rendered fine. See attached screenshot. 2) Import VM dialog The "Load" button is now aligned to the left (which is IMO actually much better than previous alignment to the right side), but now the button fills the whole width of the dialog. The button rectangle outline has the same dimensions, but it is clickable on the whole width of the dialog. This looks same in FF 45 ESR, 51, 52b2 ESR & Chr. 55. See the second screenshot attached. Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. Created attachment 1246771 [details]
VM network interface dialog
Created attachment 1246772 [details]
Import VM dialog
FailedQA in rhevm-4.1.1.4-0.1.el7.noarch ovirt-engine-webadmin-portal-4.1.1.4-0.1.el7.noarch Tested browsers: Firefox 45 ESR (currently outdated by version 52), Firefox 52 ESR, Chromium 56. (In reply to Pavel Novotny from comment #8) > FailedQA in > ovirt-engine-webadmin-portal-4.1.0.3-0.1.el7.noarch > rhevm-4.1.0.3-0.1.el7.noarch > > The trimmed input boxes and labels have been fixed, > however the fix affected another parts of the layout: > > 1) VM network interface dialog > Spacing between the "Custom MAC address" text input and "Example: 00:14..." > text is now too big so it seems that the hint text belongs to the "Up" icon > below it. > > The "Unplugged" icon at the bottom overlaps the dialog content border. > This applies only for upcoming Firefox 52b2 ESR (51 is also affected). > In Firefox 45 ESR and Chromium 55 it is rendered fine. > See attached screenshot. > This is all fixed now. The New Network Interface dialog looks fine in all tested browsers. > 2) Import VM dialog > The "Load" button is now aligned to the left > (which is IMO actually much better than previous alignment to the right > side), > but now the button fills the whole width of the dialog. The button rectangle > outline has the same dimensions, but it is clickable on the whole width of > the dialog. > This looks same in FF 45 ESR, 51, 52b2 ESR & Chr. 55. > See the second screenshot attached. This is still present in all tested browsers. The Load button still has a clickable area across the whole dialog width (with a small difference with the VMware source, but still). See the attached screencast for details. Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. Created attachment 1263781 [details]
screencast: Import VM dialog - Load button
So in master this is no longer an issue due to the switch to the bootstrap buttons, but since 4.1 hasn't done that yet the gwt buttons were being temperamental in that dialog. Verified in ovirt-engine-webadmin-portal-4.1.2-0.1.el7.noarch rhevm-4.1.2-0.1.el7.noarch Testing browsers: Firefox 52.1 ESR, Firefox 53, Chromium 57. 1) VM network interface dialog Already fixed in previous build, no changes here. 2) Import VM dialog The "Load" button now has correct size, it does not fill the whole dialog width as before. |
Created attachment 1215850 [details] screenshot Description of problem: After switching to the new list boxes, it seems that few fields are pushed down within the dialog or cut. For examples please see the v2v dialog while choosing Source to be VMware or XEN or KVM. Version-Release number of selected component (if applicable): 4.0.5 How reproducible: 100% Steps to Reproduce: search for problematic dialogs. For example: 1.open "New Network Interface" dialog (vms tab - sub tab "Network Interface" -> click New 2. or open v2v dialog (vms tab-> import->source set to vmware or zen or kvm) Actual results: few fields are cut or overriden Expected results: the fields should be positioned as before. Additional info: Please see attachments for examples