Bug 1390310

Summary:	"Override all parameters" button visible for ALL puppet modules
Product:	Red Hat Satellite	Reporter:	Evgeni Golov <egolov>
Component:	Users & Roles	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED ERRATA	QA Contact:	Shimon Shtein <sshtein>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.2.3	CC:	bbuckingham, bkearney, dhlavacd, jcallaha, mhulan, mowens, orabin, sshtein
Target Milestone:	Unspecified	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-02-21 16:54:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1479962

Description Evgeni Golov 2016-10-31 16:28:39 UTC

Description of problem:
When you create a user that can view ALL Puppet modules, but edit only some of them, the "Override all parameters" button (and the "Set parameters to defaults" one if the module already has overrides) are shown for *all* modules, not only the ones the user is allowed to edit.

Version-Release number of selected component (if applicable):
Satellite 6.2.3

How reproducible:
always

Steps to Reproduce:
1. create a user with limited rights
2. grant the user the "view_puppetclasses" permission on all modules, and "edit_puppetclasses" on one specific (e.g. with a "name = foo" search)
3. open https://sat/puppetclasses as that user, see "Override all parameters" for all classes that have parameters.

Actual results:
"override" button present for all modules

Expected results:
"override" button only present for modules the user can edit

Additional info:

Comment 2 orabin 2017-08-01 05:47:16 UTC

Moving to ON_QA because this should also be fixed by the fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1390312.

Comment 6 Satellite Program 2018-02-21 16:54:17 UTC

Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA.
> 
> For information on the advisory, and where to find the updated files, follow the link below.
> 
> If the solution does not work for you, open a new bug report.
> 
> https://access.redhat.com/errata/RHSA-2018:0336