Bug 1390382

Summary:	puppet repository goes into locked state when uploading a file that is not a puppet module
Product:	Red Hat Satellite	Reporter:	Marcelo Giles <mgiles>
Component:	Content Management	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED WONTFIX	QA Contact:	Katello QA List <katello-qa-list>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.2.3	CC:	bbuckingham, jcallaha, mhrivnak
Target Milestone:	Unspecified	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-08-02 20:59:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Marcelo Giles 2016-10-31 22:18:46 UTC

Description of problem:

When uploading puppet modules to a puppet repository, either through the GUI or using hammer, if there is a file that is not a puppet module, the repo locks. In the task list, it will show into state Paused and Result Failed. If resumed, it will go again to Result Failed.

When trying to upload more modules or deleting the repository to start fresh, it will fail with Could not delete the repository: required lock is already taken by other running tasks. Required lock: read.

One such instance happened by using the pulp-puppet-module-builder, which generates a text file named PULP_MANIFEST in the destination modules dir. Then, when using hammer to upload the content of the puppet modules dir, it will fail because of this text file and go into the locked state.

The only option to unlock it that I've found effective, was to use the foreman-rake console to destroy the paused task. This should not be required. 

Version-Release number of selected component (if applicable):
Satellite 6.2.3

How reproducible:
Whenever uploading (accidentally) a file that is not a puppet module into a puppet repository either through the GUI or using hammer. 

maybe the solution would be to add a conditional statement (both in GUI and hammer) that checks that all files in the modules dir have a .tar.gz extension and fails if it finds anything else?

Comment 2 Michael Hrivnak 2017-01-05 14:11:31 UTC

This does not appear to be a Pulp bug, so I'm changing the component.

Comment 3 Bryan Kearney 2018-08-02 20:59:29 UTC

Thank you for your interest in Satellite 6. We have evaluated this request, and we do not expect this to be implemented in the product in the forseeable future. We are therefore closing this out as WONTFIX. If you have any concerns about this, please feel free to contact Rich Jerrido or Bryan Kearney. Thank you.