Bug 1390391
Summary: | Review Request: openstack-kolla - Templates and tools from the Kolla project to build OpenStack container images | ||
---|---|---|---|
Product: | [Community] RDO | Reporter: | Steve Baker <sbaker> |
Component: | Package Review | Assignee: | hguemar |
Status: | CLOSED ERRATA | QA Contact: | hguemar |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | unspecified | CC: | chkumar, chris.brown, dmsimard, fpercoco, ggillies, hguemar, karlthered, sbaker, steven.dake |
Target Milestone: | --- | Flags: | karlthered:
rdo-review+
|
Target Release: | trunk | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-06-22 16:21:00 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1373513 |
Description
Steve Baker
2016-10-31 23:42:11 UTC
I'm asking for an empty distgit repo so I can start the packaging work, possibly basing it on some kolla packaging which ggillies did locally. I'll update the format to match bug 1342987 once I have a spec file (assigned to myself) Packaging for Kolla URL: http://git.openstack.org/cgit/openstack/kolla SPEC URL: https://github.com/steveb/kolla-distgit/blob/rpm-master/openstack-kolla.spec Wiki project URL: https://wiki.openstack.org/wiki/Kolla Project Mission: To provide production-ready containers and deployment tools for operating OpenStack clouds. openstack-kolla package description: https://github.com/steveb/kolla-distgit/blob/rpm-master/openstack-kolla.spec Hello Steve, Thanks for submitting the package review. I have added some comments on the github itself: https://github.com/steveb/kolla-distgit/commit/cfc07ca225ab879d4f49de65e9b940f4cc8e9142#diff-30526fb07e0d32c1e82ae1e1fa946867R53 You can also generate kolla configs using oslo-config-generator and docs using sphinx build. For docs: under %build section %{__python2} setup.py build_sphinx and under %files add this line %doc doc/build/html for config generation: under %install section add these lines: install -d -m 755 %{buildroot}%{_sysconfdir}/%{project}/ PYTHONPATH=. oslo-config-generator --config-file etc/oslo-config-generator/kolla-build.conf Steve, I've gone ahed and added a few comments on github following where Chandan placed them. Hope you find them helpful. Regards -steve All comments were addressed on the 16 December commit https://github.com/steveb/kolla-distgit/blob/master/openstack-kolla.spec Hey folks, thanks for working on this. Any progress? I will work on that this afternoon. Trying to build in DLRN, I got those errors. 2017-01-31 14:19:01,407 INFO:dlrn-build:DEBUG: RPM build errors: 2017-01-31 14:19:01,407 INFO:dlrn-build:DEBUG: File not found: /builddir/build/BUILDROOT/openstack-kolla-4.0.0-0.20170131131812.80db2f2.el7.centos.x86_64/usr/share/kolla/openrc-example 2017-01-31 14:19:01,408 INFO:dlrn-build:DEBUG: File not found: /builddir/build/BUILDROOT/openstack-kolla-4.0.0-0.20170131131812.80db2f2.el7.centos.x86_64/usr/bin/kolla-genpwd 2017-01-31 14:19:01,408 INFO:dlrn-build:DEBUG: File not found by glob: /builddir/build/BUILDROOT/openstack-kolla-4.0.0-0.20170131131812.80db2f2.el7.centos.x86_64/etc/kolla/* kolla-genpwd was removed by the following commit: https://github.com/openstack/kolla/commit/c07d95e1afa690d8b4f28072f4d09aa760da91d8 Since we have create a distgit in review.rdoproject.org, let's continue iterating on the spec file there. Thanks, now submitted here https://review.rdoproject.org/r/#/c/4665/ I believe this is the current patch: https://review.rdoproject.org/r/#/c/4680/ I reviewed this package using DLRN generated spec from upstream commit 80db2f2 (Spec attached below) Since this package complies with RDO Packaging Guidelines, I hereby Approve it. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 546 files have unknown license. Detailed output of licensecheck in /home/hguemar/dist-git-delorean/centos- master/data/repos/80/db/80db2f2366791b36f46f0fb708d7075d3d4d7bf6_dev /review-openstack-kolla/licensecheck.txt [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [-]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define upstream_version 4.0.0.0b4.dev14 [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: openstack-kolla-4.0.0-0.20170209151841.80db2f2.el7.centos.noarch.rpm openstack-kolla-4.0.0-0.20170209151841.80db2f2.el7.centos.src.rpm openstack-kolla.noarch: E: no-changelogname-tag openstack-kolla.noarch: W: non-conffile-in-etc /etc/kolla/kolla-build.conf openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/dind/start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/neutron/neutron-metadata-agent/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/congress/congress-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/nova/nova-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/cinder/cinder-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/haproxy/ensure_latest_config.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ironic/ironic-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/tempest/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/senlin/senlin-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/panko/panko-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/influxdb/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/grafana/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/kafka/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/kolla/template/methods.py /usr/bin/env python openstack-kolla.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/kolla/template/methods.py 644 /usr/bin/env python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/mongodb/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/iscsid/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/octavia/octavia-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/mistral/mistral-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/searchlight/searchlight-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: wrong-script-interpreter /usr/share/kolla/docker/base/set_configs.py /usr/bin/env python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/base/set_configs.py 644 /usr/bin/env python openstack-kolla.noarch: E: wrong-script-interpreter /usr/share/kolla/docker/base/start.sh /usr/local/bin/dumb-init /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/base/start.sh 644 /usr/local/bin/dumb-init /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/neutron/neutron-lbaas-agent/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/octavia/octavia-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/manila/manila-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/cinder/cinder-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/magnum/magnum-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: script-without-shebang /usr/share/kolla/docker/zaqar/Dockerfile.j2 openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/karbor/karbor-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ceph/ceph-mon/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/elasticsearch/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/magnum/magnum-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/telegraf/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/nova/nova-libvirt/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keystone/keystone/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/tacker/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/heat/heat-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/etcd/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ceph/ceph-osd/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/cron/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/congress/congress-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/sahara/sahara-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/kolla-toolbox/kolla_keystone_user.py 644 /usr/bin/python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/mistral/mistral-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/nova/nova-compute/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/rabbitmq/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/glance/glance-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/neutron/neutron-vpnaas-agent/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/trove/trove-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/karbor/karbor-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: wrong-script-interpreter /usr/share/kolla/docker/swift/swift-base/build-swift-ring.py /usr/bin/env python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/swift/swift-base/build-swift-ring.py 644 /usr/bin/env python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/monasca/monasca-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/openvswitch/openvswitch-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/chrony/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ceilometer/ceilometer-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/heka/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/aodh/aodh-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/fluentd/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/openvswitch/openvswitch-db-server/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/panko/panko-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/kibana/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/zun/zun-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/manila/manila-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/solum/solum-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/neutron/neutron-sfc-agent/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/watcher/watcher-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/kuryr/kuryr-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/cloudkitty/cloudkitty-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keystone/keystone/keystone_bootstrap.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/gnocchi/gnocchi-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/mariadb/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/nova/nova-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ironic/ironic-pxe/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/kolla-toolbox/find_disks.py 644 /usr/bin/python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ceph/ceph-mon/fetch_ceph_keys.py 644 /usr/bin/python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/nova/nova-ssh/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/designate/designate-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/zookeeper/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/cinder/cinder-volume/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keystone/keystone-ssh/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/searchlight/searchlight-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/openvswitch/openvswitch-vswitchd/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: zero-length /usr/share/kolla/docker/base/apt_preferences.ubuntu openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/swift/swift-base/swift-rootwrap 644 /usr/bin/python2 openstack-kolla.noarch: W: hidden-file-or-dir /usr/share/kolla/doc/template-override/.keep openstack-kolla.noarch: E: zero-length /usr/share/kolla/doc/template-override/.keep openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/glance/glance-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/rabbitmq/rabbitmq_get_gospel_node.py 644 /usr/bin/python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/solum/solum-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/sahara/sahara-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ironic/ironic-inspector/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/watcher/watcher-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/cloudkitty/cloudkitty-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/designate/designate-central/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/trove/trove-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/zun/zun-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/gnocchi/gnocchi-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/rally/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/mariadb/security_reset.expect 644 /usr/bin/expect -f openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/collectd/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/murano/murano-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/heat/heat-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keepalived/check_alive.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keystone/keystone-fernet/keystone_bootstrap.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keystone/keystone-fernet/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/kolla-toolbox/kolla_sanity.py 644 /usr/bin/python openstack-kolla.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/kolla/template/filters.py /usr/bin/env python openstack-kolla.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/kolla/template/filters.py 644 /usr/bin/env python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/senlin/senlin-api/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/kolla-toolbox/kolla_keystone_service.py 644 /usr/bin/python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/horizon/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keystone/keystone-fernet/fetch_fernet_tokens.py 644 /usr/bin/python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ironic/ironic-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/neutron/neutron-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/murano/murano-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/kolla/image/build.py /usr/bin/env python openstack-kolla.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/kolla/image/build.py 644 /usr/bin/env python openstack-kolla.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/kolla/cmd/build.py /usr/bin/env python openstack-kolla.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/kolla/cmd/build.py 644 /usr/bin/env python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/swift/swift-rsyncd/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ceilometer/ceilometer-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ceph/ceph-base/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/neutron/neutron-server/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keepalived/extend_start.sh 644 /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/openvswitch/openvswitch-db-server/ovs_ensure_configured.sh 644 /bin/bash openstack-kolla.noarch: W: no-manual-page-for-binary kolla-build openstack-kolla.src: E: no-changelogname-tag openstack-kolla.src: W: invalid-url Source0: kolla-4.0.0.0b4.dev14-0.20170209151841.80db2f2.tar.gz 2 packages and 0 specfiles checked; 129 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- openstack-kolla.noarch: E: no-changelogname-tag openstack-kolla.noarch: W: invalid-url URL: http://pypi.python.org/pypi/kolla <urlopen error [Errno -2] Name or service not known> openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/dind/start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ceph/ceph-osd/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/mistral/mistral-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/mistral/mistral-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keepalived/check_alive.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/glance/glance-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/zookeeper/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/karbor/karbor-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/murano/murano-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ceilometer/ceilometer-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/congress/congress-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/nova/nova-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/searchlight/searchlight-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/rabbitmq/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/trove/trove-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/nova/nova-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keepalived/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/kolla/cmd/build.py 0644L /usr/bin/env openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/senlin/senlin-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: wrong-script-interpreter /usr/share/kolla/docker/base/start.sh /usr/local/bin/dumb-init openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/base/start.sh 0644L /usr/local/bin/dumb-init openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/mariadb/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/nova/nova-ssh/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/sahara/sahara-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/octavia/octavia-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/kolla-toolbox/find_disks.py 0644L /usr/bin/python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/base/set_configs.py 0644L /usr/bin/env openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/neutron/neutron-server/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keystone/keystone-ssh/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/swift/swift-base/swift-rootwrap 0644L /usr/bin/python2 openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/panko/panko-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ceph/ceph-mon/fetch_ceph_keys.py 0644L /usr/bin/python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/cinder/cinder-volume/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/monasca/monasca-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/congress/congress-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ironic/ironic-pxe/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/mariadb/security_reset.expect 0644L /usr/bin/expect openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keystone/keystone/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/openvswitch/openvswitch-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/searchlight/searchlight-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/cinder/cinder-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/nova/nova-libvirt/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/swift/swift-rsyncd/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/designate/designate-central/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/aodh/aodh-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/glance/glance-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/zun/zun-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/collectd/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/telegraf/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/kolla-toolbox/kolla_keystone_service.py 0644L /usr/bin/python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/cloudkitty/cloudkitty-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/magnum/magnum-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/heat/heat-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: zero-length /usr/share/kolla/docker/base/apt_preferences.ubuntu openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/zun/zun-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/rally/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ceilometer/ceilometer-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/heat/heat-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/rabbitmq/rabbitmq_get_gospel_node.py 0644L /usr/bin/python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/cinder/cinder-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/sahara/sahara-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/neutron/neutron-vpnaas-agent/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/openvswitch/openvswitch-db-server/ovs_ensure_configured.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/nova/nova-compute/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ironic/ironic-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/gnocchi/gnocchi-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/influxdb/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/kolla-toolbox/kolla_keystone_user.py 0644L /usr/bin/python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/watcher/watcher-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/neutron/neutron-lbaas-agent/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/elasticsearch/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keystone/keystone-fernet/fetch_fernet_tokens.py 0644L /usr/bin/python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/etcd/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/solum/solum-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/karbor/karbor-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/haproxy/ensure_latest_config.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/neutron/neutron-sfc-agent/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ironic/ironic-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: script-without-shebang /usr/share/kolla/docker/zaqar/Dockerfile.j2 openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/cloudkitty/cloudkitty-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/horizon/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/mongodb/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/kibana/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/grafana/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/kolla/image/build.py 0644L /usr/bin/env openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/senlin/senlin-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/heka/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/fluentd/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/chrony/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/kafka/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/murano/murano-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/openvswitch/openvswitch-vswitchd/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ceph/ceph-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/magnum/magnum-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/trove/trove-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/watcher/watcher-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: W: non-conffile-in-etc /etc/kolla/kolla-build.conf openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/solum/solum-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ironic/ironic-inspector/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/neutron/neutron-metadata-agent/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/gnocchi/gnocchi-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/manila/manila-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/kolla/template/filters.py 0644L /usr/bin/env openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/neutron/neutron-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/kuryr/kuryr-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/swift/swift-base/build-swift-ring.py 0644L /usr/bin/env openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keystone/keystone-fernet/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/panko/panko-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/cron/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/kolla-toolbox/kolla_sanity.py 0644L /usr/bin/python openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/iscsid/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/octavia/octavia-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/tempest/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keystone/keystone-fernet/keystone_bootstrap.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/keystone/keystone/keystone_bootstrap.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/openvswitch/openvswitch-db-server/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/tacker/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/manila/manila-api/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/designate/designate-base/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/kolla/template/methods.py 0644L /usr/bin/env openstack-kolla.noarch: W: hidden-file-or-dir /usr/share/kolla/doc/template-override/.keep openstack-kolla.noarch: E: zero-length /usr/share/kolla/doc/template-override/.keep openstack-kolla.noarch: E: non-executable-script /usr/share/kolla/docker/ceph/ceph-mon/extend_start.sh 0644L /bin/bash openstack-kolla.noarch: W: no-manual-page-for-binary kolla-build 1 packages and 0 specfiles checked; 122 errors, 4 warnings. Requires -------- openstack-kolla (rpmlib, GLIBC filtered): /bin/bash /usr/bin/python2 GitPython python(abi) python-crypto python-docker-py python-gitdb python-jinja2 python-netaddr python-setuptools python-six python2-oslo-config Provides -------- openstack-kolla: openstack-kolla Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -n openstack-kolla -p -m rdo-mitaka-el7 --define DISTTAG=el7 Buildroot used: cloud7-openstack-mitaka-el7-build-repo_20520 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, EPEL5, BATCH, EPEL6 --------------------------------------------------------------- %global dlrn 1 %define upstream_version 4.0.0.0b4.dev14 %{!?upstream_version: %global upstream_version %{version}%{?milestone}} Name: openstack-kolla Version: 4.0.0 Release: 0.20170209151841.80db2f2%{?dist} Summary: Build OpenStack container images License: ASL 2.0 URL: http://pypi.python.org/pypi/kolla Source0: kolla-4.0.0.0b4.dev14-0.20170209151841.80db2f2.tar.gz BuildArch: noarch BuildRequires: python-setuptools BuildRequires: python2-devel BuildRequires: python-pbr BuildRequires: python2-oslo-config Requires: python-setuptools Requires: python-gitdb Requires: GitPython Requires: python-jinja2 Requires: python-docker-py Requires: python-six Requires: python2-oslo-config Requires: python-crypto Requires: python-netaddr %description Templates and tools from the Kolla project to build OpenStack container images. %prep %setup -q -n kolla-%{upstream_version} %build PYTHONPATH=. oslo-config-generator --config-file=etc/oslo-config-generator/kolla-build.conf %py2_build %install %py2_install mkdir -p %{buildroot}%{_datadir}/kolla/docker cp -vr docker/ %{buildroot}%{_datadir}/kolla # setup.cfg required for kolla-build to discover the version install -p -D -m 644 setup.cfg %{buildroot}%{_datadir}/kolla/setup.cfg # remove tests rm -fr %{buildroot}%{python2_sitelib}/kolla/tests # remove tools rm -fr %{buildroot}%{_datadir}/kolla/tools install -d -m 755 %{buildroot}%{_sysconfdir}/kolla cp -v %{buildroot}%{_datadir}/kolla/etc_examples/kolla/kolla-build.conf %{buildroot}%{_sysconfdir}/kolla rm -fr %{buildroot}%{_datadir}/kolla/etc_examples %files %doc README.rst %doc %{_datadir}/kolla/doc %license LICENSE %{_bindir}/kolla-build %{python2_sitelib}/kolla* %{_datadir}/kolla %{_sysconfdir}/kolla %changelog This landed so closing. |