Bug 1390590

Summary: Correct build of the evolution part
Product: [Fedora] Fedora Reporter: Milan Crha <mcrha>
Component: mail-notificationAssignee: Dmitry Butskoy <dmitry>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 25CC: dmitry, erik-fedora
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-01 23:39:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
proposed patch (.spec file + the new build patch) none

Description Milan Crha 2016-11-01 13:31:29 UTC 
Created attachment 1216115 [details]
proposed patch (.spec file + the new build patch)

As notified by this upstream comment:
https://bugzilla.gnome.org/show_bug.cgi?id=764065#c18
The mail-notification package will require changes to be made for the upcoming Camel API changes, to be done for 3.23.2 of the evolution-data-server. More at that bug report and at
https://mail.gnome.org/archives/desktop-devel-list/2016-October/msg00078.html

While I've been trying to build the mail-notification with the evolution=yes, it didn't want to. The attached is a patch which:
a) declares "evolution=yes/no" in the configure, based on the "with evolution"
   variable value
b) corrects detection of the plugindir (this avoided the evolution part build)
c) prepares for changes outlined in the above upstream bug report.

With this patch added, I guess you can even enable the evolution subpackage again. It can be done even before 3.23.2 is out, because the patch is backward compatible, though a rebuild of the package will be needed once the 3.23.2 is out.

I'd like to ask you to upstream the mail-notification-eds3_23_2.patch, thus the maintainer of the clone, and its users, can benefit from the change too.
Comment 1 Dmitry Butskoy 2016-11-01 23:39:34 UTC 
Thanks. Applied for rawhide.

The cloned upstream (stalled for 3 years) was created by erik-fedora, who co-maintained in Fedora too. I hope he can see the bug reports and can take the patch for upstream.

Evolution plugin was dropped 2 year ago (due to stalled upstream etc.), and nobody complains aboit it. I think it is better to continue with default of "evolution=no", surely preserving "bcond_with".
Comment 2 Milan Crha 2016-11-02 12:57:15 UTC 
(In reply to Dmitry Butskoy from comment #1)
> Thanks. Applied for rawhide.

You are welcome and thanks for a quick action on this.

> I think it is better to continue with default of
> "evolution=no", surely preserving "bcond_with".

Please note that the default is 'evolution=yes', which is the reason why I added the configure option to the .spec file. The ./jb silently sets "evolution=no", when it cannot find necessary evolution bits, which is the evolution-plugin-3.0.pc file, which had been removed couple years ago. With this patch applied and the evolution-devel being available during the configure the evolution part would be built without the added option.