Bug 1390608
Summary: | Review Request: vitrage-dashboard Horizon plugin for vitrage | ||
---|---|---|---|
Product: | [Community] RDO | Reporter: | Eyal <eyalb1> |
Component: | Package Review | Assignee: | Matthias Runge <mrunge> |
Status: | CLOSED NEXTRELEASE | QA Contact: | hguemar |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | trunk | CC: | apevec, brault, eyalb1, jpena, mrunge |
Target Milestone: | --- | Flags: | mrunge:
rdo-review+
|
Target Release: | trunk | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-02-16 17:07:38 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1410778 |
Description
Eyal
2016-11-01 14:03:57 UTC
sent a pull request to fix minor issues, currently preventing it building. merged it thanks another pull request. Based on my specfile: https://raw.githubusercontent.com/mrunge/vitrage-dashboard/master/openstack-vitrage-ui.spec I have a copr repo with all vitrage components: https://copr.fedorainfracloud.org/coprs/mrunge/vitrage/ vitrage-dashboard bundles third party libraries, which are already used by horizon (d3) and others. Please unbundle them. https://github.com/openstack/vitrage-dashboard/tree/master/vitragedashboard/static/vendor Hi Can you push the change to openstack gerrit so the ui guys can approve it thanks I'd drop the vendor directory completely. That won't be accepted. It requires generating XStatic packages for those deps not already included in OpenStack packages. another issue I found from playing around with the package is: API pieces are currently missing yes now I see that from the devstack installation https://github.com/openstack/vitrage-dashboard/blob/master/devstack/plugin.sh#L10 the api is copied I guess we need to do the same in the spec file There doesn't seem to be a requirement for copying api over. E.g see ironic-ui: https://github.com/openstack/ironic-ui since https://github.com/openstack/vitrage-dashboard/commit/7b4cbda9305402fb97714a261a198cf362fb6de2 was merged, we don't need to copy API over any more. Please tag a new release and include that into the package. Was new release tagged as requested in comment 10 ? Answering myself, there isn't a release yet which includes Matthias' fix from comment 10. But we can proceed with RDO Trunk review which builds from master. Here is the licensecheck output, project is APLv2 licensed: vitrage-dashboard/.coveragerc: *No copyright* UNKNOWN vitrage-dashboard/.gitreview: *No copyright* UNKNOWN vitrage-dashboard/.jshintrc: *No copyright* UNKNOWN vitrage-dashboard/.mailmap: *No copyright* UNKNOWN vitrage-dashboard/.testr.conf: *No copyright* UNKNOWN vitrage-dashboard/CONTRIBUTING.rst: *No copyright* UNKNOWN vitrage-dashboard/HACKING.rst: *No copyright* UNKNOWN vitrage-dashboard/LICENSE: *No copyright* Apache (v2.0) vitrage-dashboard/MANIFEST.in: *No copyright* UNKNOWN vitrage-dashboard/README.rst: *No copyright* UNKNOWN vitrage-dashboard/babel.cfg: *No copyright* UNKNOWN vitrage-dashboard/openstack-common.conf: *No copyright* UNKNOWN vitrage-dashboard/requirements.txt: *No copyright* UNKNOWN vitrage-dashboard/setup.cfg: *No copyright* Apache vitrage-dashboard/setup.py: Apache (v2.0) GENERATED FILE vitrage-dashboard/test-requirements.txt: *No copyright* UNKNOWN vitrage-dashboard/tox.ini: *No copyright* UNKNOWN The following files have been reviewed in Gerrit: - Spec: https://raw.githubusercontent.com/rdo-packages/vitrage-dashboard-distgit/rpm-master/openstack-vitrage-ui.spec - SRPM: http://46.231.132.68:8080/v1/AUTH_b50e80d3969f441a8b7b1fe831003e0a/rdoartifacts/67/4667/11/gate/DLRN-rpmbuild/Z20e036e1b2594625bb9a8d818fda84ae/artifacts/centos/repos/b7/3c/b73c3875060c865628316c85386197986df95441_dev/openstack-vitrage-ui-1.1.1-0.20170201134555.b73c387.el7.centos.src.rpm Please note that the SRPM has been generated by DLRN, so some differences are expected (Version, Release and Source0). what's the next step ? the ocata and ocata-uc tags were uncommented in rdo.yaml what do I need to do so I can see get the rpms from rdo ? Matthias, can you have a look at the spec/SRPM, and set rdo-review+ if appropriate? comments 4 and 6 are not addressed. could you please include a comment about licenses of bundled libraries? Some of them are a bit dated already. Maybe it makes sense to remove them and to use the ones used in horizon? (e.g d3?) to elaborate more: d3 lib is not licensed under ASL 2.0, as hinted in license field in the spec file. I updated the spec file with license ASL and BSD https://review.rdoproject.org/r/#/c/4873/ Matthias, please check PS2 in https://review.rdoproject.org/r/4873 left my comment on the review. We now have builds for vitrage-dashboard in the RDO Trunk repos. |