Bug 1390616

Summary:	Review Request: snapd-glib - Library providing a GLib interface to snapd
Product:	[Fedora] Fedora	Reporter:	Zygmunt Krynicki <me>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-04-09 02:53:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Zygmunt Krynicki 2016-11-01 14:15:15 UTC

Spec URL: https://fedorapeople.org/~zyga/snapd-glib.spec
SRPM URL: https://fedorapeople.org/~zyga/snapd-glib-1.2-1.fc24.src.rpm
Description:
snaps-glib is a library that provides an interface to communicate
with snapd.

Fedora Account System Username: zyga

Comment 1 Neal Gompa 2016-11-01 14:45:19 UTC

Taking this review.

Comment 2 Neal Gompa 2016-11-01 14:58:23 UTC

Running it through mock causes it to fail to build indicating undefined macro AC_PROG_INTLTOOL.

Please check and make sure all of your build dependencies are specified.

Comment 3 Zygmunt Krynicki 2016-11-01 15:08:02 UTC

Fixed and passed through mock now. Drops on fedorapepople updated.

Comment 4 Neal Gompa 2016-11-01 15:41:33 UTC

One issue remaining: The summary ends in a period, which makes rpmlint unhappy. Drop the period at the end of summary lines.


Aside from that:

- Package is named appropriately
- Licensing is properly declared
- Complies with Fedora Packaging Guidelines on packaging libraries

Fix the summary issue on upload, and I think we're gravy.

PACKAGE APPROVED

Comment 5 Gwyn Ciesla 2016-11-01 15:52:45 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/snapd-glib

Comment 6 Fedora Update System 2016-11-01 16:26:14 UTC

snapd-glib-1.2-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a7ded88c6

Comment 7 Fedora Update System 2016-11-01 16:28:01 UTC

snapd-glib-1.2-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-38ea79bbec

Comment 8 Fedora Update System 2016-11-01 16:28:49 UTC

snapd-glib-1.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e2ee0e99f1

Comment 9 Fedora Update System 2017-03-31 19:34:57 UTC

snapd-2.23.6-1.fc26 snapd-glib-1.9-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

Comment 10 Fedora Update System 2017-03-31 19:37:30 UTC

snapd-glib-1.9-2.fc25 snapd-2.23.6-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

Comment 11 Fedora Update System 2017-03-31 19:40:14 UTC

snapd-glib-1.9-2.fc24 snapd-2.23.6-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

Comment 12 Fedora Update System 2017-04-01 23:22:30 UTC

snapd-2.23.6-2.fc24, snapd-glib-1.9-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

Comment 13 Fedora Update System 2017-04-01 23:25:15 UTC

snapd-2.23.6-2.fc25, snapd-glib-1.9-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

Comment 14 Fedora Update System 2017-04-02 00:52:13 UTC

snapd-2.23.6-2.fc26, snapd-glib-1.9-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

Comment 15 Fedora Update System 2017-04-02 00:56:07 UTC

snapd-2.23.6-3.fc26 snapd-glib-1.9-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

Comment 16 Fedora Update System 2017-04-02 00:58:01 UTC

snapd-2.23.6-3.fc24 snapd-glib-1.9-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

Comment 17 Fedora Update System 2017-04-02 00:58:42 UTC

snapd-2.23.6-3.fc25 snapd-glib-1.9-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

Comment 18 Fedora Update System 2017-04-03 02:20:35 UTC

snapd-2.23.6-3.fc24, snapd-glib-1.9-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

Comment 19 Fedora Update System 2017-04-03 02:20:53 UTC

snapd-2.23.6-3.fc25, snapd-glib-1.9-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

Comment 20 Fedora Update System 2017-04-03 03:51:40 UTC

snapd-2.23.6-3.fc26, snapd-glib-1.9-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

Comment 21 Fedora Update System 2017-04-05 13:38:00 UTC

snapd-2.23.6-4.fc26 snapd-glib-1.10-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

Comment 22 Fedora Update System 2017-04-05 13:39:16 UTC

snapd-2.23.6-4.fc25 snapd-glib-1.10-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

Comment 23 Fedora Update System 2017-04-05 13:40:39 UTC

snapd-2.23.6-3.fc24 snapd-glib-1.10-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

Comment 24 Fedora Update System 2017-04-05 19:53:36 UTC

snapd-2.23.6-3.fc24, snapd-glib-1.10-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

Comment 25 Fedora Update System 2017-04-05 19:53:36 UTC

snapd-2.23.6-4.fc25, snapd-glib-1.10-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

Comment 26 Fedora Update System 2017-04-05 21:53:49 UTC

snapd-2.23.6-4.fc26, snapd-glib-1.10-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

Comment 27 Fedora Update System 2017-04-09 02:53:50 UTC

snapd-2.23.6-4.fc25, snapd-glib-1.10-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 28 Fedora Update System 2017-04-09 05:58:32 UTC

snapd-2.23.6-4.fc26, snapd-glib-1.10-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 29 Fedora Update System 2017-04-09 10:19:47 UTC

snapd-2.23.6-3.fc24, snapd-glib-1.10-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.