Bug 1390744

Summary:	Error in sos_commands/openstack_nova/nova_config_list and nova_flavor_list output
Product:	Red Hat OpenStack	Reporter:	Wesley Duffee-Braun <wduffee>
Component:	sos-plugins-openstack	Assignee:	Lee Yarwood <lyarwood>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Shai Revivo <srevivo>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	7.0 (Kilo)	CC:	apevec, bmr, lhh, lyarwood, mburns, plambri, srevivo
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-06 10:04:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Wesley Duffee-Braun 2016-11-01 19:33:54 UTC

Description of problem:
When running the 'sosreport -k openstack_nova.cmds=on' on a RHOS 7 Controller node, the nova_config_list and nova_flavor_list files indicate errors.

Version-Release number of selected component (if applicable):
sos-3.2-36.el7ost.1.noarch
openstack-nova-common-2015.1.2-18.el7ost.noarch

How reproducible:
Always

Steps to Reproduce:
1. From a controller node, run 'sosreport -k openstack_nova.cmds=on'
2. Extract the resulting sosreport
3. Examine the sos_commands/openstack_nova/nova_config_list and nova_flavor_list files

Actual results:
openstack_nova]# grep 'error: argument' *
nova_config_list:nova-manage: error: argument category: invalid choice: 'config' (choose from 'version', 'bash-completion', 'shell', 'logs', 'db', 'vm', 'agent', 'host', 'floating', 'vpn', 'api_db', 'project', 'account', 'network', 'service', 'cell', 'fixed')
nova_flavor_list:nova-manage: error: argument category: invalid choice: 'flavor' (choose from 'version', 'bash-completion', 'shell', 'logs', 'db', 'vm', 'agent', 'host', 'floating', 'vpn', 'api_db', 'project', 'account', 'network', 'service', 'cell', 'fixed')

Expected results:
Correct information is stored in the files.

Maybe the nova_flavor_list (populated by 'nova-manage flavor list') should be 'openstack flavor list' ?

Comment 1 Bryn M. Reeves 2016-11-02 09:05:59 UTC

Sounds about right, Lee?

Comment 2 Lee Yarwood 2016-11-02 09:39:38 UTC

(In reply to Bryn M. Reeves from comment #1)
> Sounds about right, Lee?

Well a new plugin really needs to be created to capture output from the `openstack` command. It's a separate entity that hasn't always been provided by OSP and thus may or may not be present on a host. I'd rather see the following backported into the RHEL 7.3 version :

https://github.com/sosreport/sos/commit/70dec0664a6ab69c57b89eb8519efdf8d98f9763

Happy to do this myself or to reassign this bug to the default assignee for the RHEL component if needed.

Comment 3 Bryn M. Reeves 2016-11-02 10:14:43 UTC

> I'd rather see the following backported into the RHEL 7.3 version :
> https://github.com/sosreport/sos/commit/70dec0664a6ab69c57b89eb8519efdf8d98f9763

That commit is in 3.3, so it is already in 7.3.

If 'nova flavor list' is a valid command then this can be closed when the updated package hits RHOS and there's no further action needed.

If it isn't then this bug can be used to address that on z-stream if necessary.

Comment 4 Bryn M. Reeves 2016-11-02 10:15:39 UTC

This is currently assigned to the sos-plugins-openstack component (which should be obsolete).

If there's no separate maintenance being done for sos in RHOS now then this can be moved to RHEL/sos if there is still work to be done.

Comment 5 Lee Yarwood 2017-01-06 10:04:30 UTC

Closing as CURRENTRELEASE given the commit listed in c#2 is now part of RHEL 7.3 sos.