Bug 1390915

Summary:	false-positive monitoring operation result of fence_ipmilan stonith resource
Product:	Red Hat Enterprise Linux 7	Reporter:	Josef Zimek <pzimek>
Component:	fence-agents	Assignee:	Marek Grac <mgrac>
Status:	CLOSED ERRATA	QA Contact:	cluster-qe <cluster-qe>
Severity:	unspecified	Docs Contact:
Priority:	high
Version:	7.4	CC:	cfeist, cluster-maint, jhan, jruemker, mjuricek, nwahl
Target Milestone:	rc	Keywords:	EasyFix, ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	fence-agents-4.0.11-49.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1397888 1397889 (view as bug list)		Environment:
Last Closed:	2017-08-01 16:10:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1394959, 1397888, 1397889

Description Josef Zimek 2016-11-02 09:05:27 UTC

Description of problem:

When fence_ipmilan stonith resource is configured with unreachable IP address the resource starts and reports successful monitoring operation checks:



# ping -w1 -c5 10.10.10.20
PING 10.10.10.20 (10.10.10.20) 56(84) bytes of data.

--- 10.10.10.20 ping statistics ---
2 packets transmitted, 0 received, 100% packet loss, time 999ms



# pcs stonith create fence_lojza2 fence_ipmilan ipaddr="10.10.10.20" login="login" passwd="password" verbose=true op monitor interval=5 timeout=20


pcs config:

 Resource: fence_lojza2 (class=stonith type=fence_ipmilan)
  Attributes: ipaddr=10.10.10.20 login=login passwd=password verbose=true 
  Operations: monitor interval=5 timeout=20 (fence_lojza2-monitor-interval-5)


pcs staus:


 fence_lojza2	(stonith:fence_ipmilan):	Started virt-018



set debug logging on stonit-ng component

monitoring is successful even if IP 10.10.10.20 is not reachable from my test system:


Oct 28 17:11:31 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: stonith_device_execute:	Operation monitor on fence_lojza2 now running with pid=2833, timeout=20s
Oct 28 17:11:31 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: stonith_action_async_done:	Child process 2833 performing action 'monitor' exited with rc 0
Oct 28 17:11:31 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: st_child_done:	Operation 'monitor' on 'fence_lojza2' completed with rc=0 (0 remaining)
Oct 28 17:11:31 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: log_operation:	Operation 'monitor' [2833] for device 'fence_lojza2' returned: 0 (OK)
Oct 28 17:11:31 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: log_operation:	fence_lojza2:2833 [ NOTICE: List option is not working on this device yet ]
Oct 28 17:11:36 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: stonith_command:	Processing st_execute 14 from lrmd.2536 (               0)
Oct 28 17:11:36 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: schedule_stonith_command:	Scheduling monitor on fence_lojza2 for 91607a7b-8023-4f7c-9b1f-3f4fbbf47fa7 (timeout=20s)
Oct 28 17:11:36 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: stonith_command:	Processed st_execute from lrmd.2536: Operation now in progress (-115)
Oct 28 17:11:36 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: stonith_action_create:	Initiating action monitor for agent fence_ipmilan (target=(null))
Oct 28 17:11:36 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: internal_stonith_action_execute:	forking
Oct 28 17:11:36 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: internal_stonith_action_execute:	sending args
Oct 28 17:11:36 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: stonith_device_execute:	Operation monitor on fence_lojza2 now running with pid=2838, timeout=20s
Oct 28 17:11:36 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: stonith_action_async_done:	Child process 2838 performing action 'monitor' exited with rc 0
Oct 28 17:11:36 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: st_child_done:	Operation 'monitor' on 'fence_lojza2' completed with rc=0 (0 remaining)
Oct 28 17:11:36 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: log_operation:	Operation 'monitor' [2838] for device 'fence_lojza2' returned: 0 (OK)
Oct 28 17:11:36 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: log_operation:	fence_lojza2:2838 [ NOTICE: List option is not working on this device yet ]
Oct 28 17:11:41 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: stonith_command:	Processing st_execute 15 from lrmd.2536 (               0)
Oct 28 17:11:41 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: schedule_stonith_command:	Scheduling monitor on fence_lojza2 for 91607a7b-8023-4f7c-9b1f-3f4fbbf47fa7 (timeout=20s)
Oct 28 17:11:41 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: stonith_command:	Processed st_execute from lrmd.2536: Operation now in progress (-115)
Oct 28 17:11:41 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: stonith_action_create:	Initiating action monitor for agent fence_ipmilan (target=(null))
Oct 28 17:11:41 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: internal_stonith_action_execute:	forking
Oct 28 17:11:41 [2535] virt-018.cluster-qe.lab.eng.brq.redhat.com stonith-ng:    debug: internal_stonith_action_execute:	sending args


Version-Release number of selected component (if applicable):

fence-agents-ipmilan-4.0.11-27.el7_2.7.x86_64


Actual results:

monitoring operation of stonith resource is successful even if configured IP of stonith device is not available

Expected results:


If IP of stonith device is not reachable then monitoring operation should result with failed status

Comment 1 Marek Grac 2016-11-02 09:18:50 UTC

Already fixed in upstream

https://github.com/ClusterLabs/fence-agents/commit/65654f9f9095b273214a6d75df3aec04ff2d7bff

Comment 5 Marek Grac 2016-11-18 10:02:31 UTC

*** Bug 1396111 has been marked as a duplicate of this bug. ***

Comment 9 Marek Grac 2016-11-23 15:18:34 UTC

Test:

fence_ipmilan -o monitor -l ipmi -p ipmi -a ipmi

Before:
NOTICE: List option is not working on this device yet
$? = 0

After:
Failed: Unable to obtain correct plug status or plug is not available
$? = 1

Comment 13 errata-xmlrpc 2017-08-01 16:10:32 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:1874