Bug 1390924

/usr/bin/katello-backup:73:    '/var/lib/puppet/foreman_cache_data',
/usr/bin/katello-backup:74:    '/var/lib/puppet/ssl'

Created redmine issue http://projects.theforeman.org/issues/18117 from this bug

Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/18117 has been resolved.

FailedQA.

The changes make it failing even on puppet3 Satellite and on puppet4 Satellite

# katello-backup bkp
...
Backing up config files... 
Failed 'tar --selinux --create --gzip --file=bkp/katello-backup-20170808075949/config_files.tar.gz --listed-incremental=bkp/katello-backup-20170808075949/.config.snar /etc/foreman-proxy /etc/httpd /etc/foreman-installer /etc/pki/katello /etc/pki/katello-certs-tools /etc/pki/pulp /etc/pulp /etc/puppet /etc/qpid /etc/qpid-dispatch /root/ssl-build /var/www/html/pub /etc/squid /etc/puppetlabs /opt/puppetlabs/puppet/cache/foreman_cache_data /opt/puppetlabs/puppet/ssl/ /var/lib/puppet/foreman_cache_data /var/lib/puppet/ssl /etc/candlepin /etc/foreman /etc/hammer /etc/sysconfig/tomcat* /etc/tomcat* /var/lib/candlepin 2>/dev/null' with exit code 141

# ll bkp/katello-backup-20170808075949/config_files.tar.gz
ls: cannot access bkp/katello-backup-20170808075949/config_files.tar.gz: No such file or directory


Running tar command separately makes it obvious why tar is failing
Non-existent directories
On puppet4 Satellite it's p3 dirs, on puppet3 Satellite it's p4 dirs

# tar --selinux --create --gzip --file=bkp/katello-backup-20170808075949/config_files.tar.gz --listed-incremental=bkp/katello-backup-20170808075949/.config.snar /etc/foreman-proxy /etc/httpd /etc/foreman-installer /etc/pki/katello /etc/pki/katello-certs-tools /etc/pki/pulp /etc/pulp /etc/puppet /etc/qpid /etc/qpid-dispatch /root/ssl-build /var/www/html/pub /etc/squid /etc/puppetlabs /opt/puppetlabs/puppet/cache/foreman_cache_data /opt/puppetlabs/puppet/ssl/ /var/lib/puppet/foreman_cache_data /var/lib/puppet/ssl /etc/candlepin /etc/foreman /etc/hammer /etc/sysconfig/tomcat* /etc/tomcat* /var/lib/candlepin
tar: /etc/puppet: Cannot stat: No such file or directory
tar: /var/lib/puppet/foreman_cache_data: Cannot stat: No such file or directory
tar: /var/lib/puppet/ssl: Cannot stat: No such file or directory
tar: Removing leading `/' from member names
tar: /etc/puppet: Cannot stat: No such file or directory
tar: /var/lib/puppet/foreman_cache_data: Cannot stat: No such file or directory
tar: /var/lib/puppet/ssl: Cannot stat: No such file or directory
tar: Exiting with failure status due to previous errors

Is there tar option to ignore this type of errors?

@satellite-6.3.0-16.0.beta.el7sat.noarch
katello-common-3.4.4-2.el7sat.noarch

(In reply to Lukas Pramuk from comment #6)
> FailedQA.
> 
> The changes make it failing even on puppet3 Satellite and on puppet4
> Satellite
> 
> # katello-backup bkp
> ...
> Backing up config files... 
> Failed 'tar --selinux --create --gzip
> --file=bkp/katello-backup-20170808075949/config_files.tar.gz
> --listed-incremental=bkp/katello-backup-20170808075949/.config.snar
> /etc/foreman-proxy /etc/httpd /etc/foreman-installer /etc/pki/katello
> /etc/pki/katello-certs-tools /etc/pki/pulp /etc/pulp /etc/puppet /etc/qpid
> /etc/qpid-dispatch /root/ssl-build /var/www/html/pub /etc/squid
> /etc/puppetlabs /opt/puppetlabs/puppet/cache/foreman_cache_data
> /opt/puppetlabs/puppet/ssl/ /var/lib/puppet/foreman_cache_data
> /var/lib/puppet/ssl /etc/candlepin /etc/foreman /etc/hammer
> /etc/sysconfig/tomcat* /etc/tomcat* /var/lib/candlepin 2>/dev/null' with
> exit code 141
> 
> # ll bkp/katello-backup-20170808075949/config_files.tar.gz
> ls: cannot access bkp/katello-backup-20170808075949/config_files.tar.gz: No
> such file or directory
> 
> 
> Running tar command separately makes it obvious why tar is failing
> Non-existent directories
> On puppet4 Satellite it's p3 dirs, on puppet3 Satellite it's p4 dirs
> 
> # tar --selinux --create --gzip
> --file=bkp/katello-backup-20170808075949/config_files.tar.gz
> --listed-incremental=bkp/katello-backup-20170808075949/.config.snar
> /etc/foreman-proxy /etc/httpd /etc/foreman-installer /etc/pki/katello
> /etc/pki/katello-certs-tools /etc/pki/pulp /etc/pulp /etc/puppet /etc/qpid
> /etc/qpid-dispatch /root/ssl-build /var/www/html/pub /etc/squid
> /etc/puppetlabs /opt/puppetlabs/puppet/cache/foreman_cache_data
> /opt/puppetlabs/puppet/ssl/ /var/lib/puppet/foreman_cache_data
> /var/lib/puppet/ssl /etc/candlepin /etc/foreman /etc/hammer
> /etc/sysconfig/tomcat* /etc/tomcat* /var/lib/candlepin
> tar: /etc/puppet: Cannot stat: No such file or directory
> tar: /var/lib/puppet/foreman_cache_data: Cannot stat: No such file or
> directory
> tar: /var/lib/puppet/ssl: Cannot stat: No such file or directory
> tar: Removing leading `/' from member names
> tar: /etc/puppet: Cannot stat: No such file or directory
> tar: /var/lib/puppet/foreman_cache_data: Cannot stat: No such file or
> directory
> tar: /var/lib/puppet/ssl: Cannot stat: No such file or directory
> tar: Exiting with failure status due to previous errors
> 
> Is there tar option to ignore this type of errors?

This looks like you are writing the backup to a directory to which postgres does not have access to write. I believe it's in the docs that this is required? So basically, needs to be written to /tmp and then pushed to whatever location you like afterwards

Verified with Sat6.3 snap 17.

Tried with both puppet 3 and 4 and checked whether:
1) katello-backup ran without errors
2) either files for puppet 3, OR files for puppet 4 are present in the archive

For puppet 3:
/etc/puppet

For puppet 4:
/etc/puppetlabs

The files are indeed present. Actually, as on puppet 4 machine, the puppet has been upgraded from puppet 3, there are both directories present: which is probably not necessary but is on the safe side.

Commit review shows the result has been achieved by trying to tar both paths and redirecting output to /dev/null which doesn't look like a good practice to me. However, the issue is fixed and no regression found -> verified.


Note: when running katello-backup, you MUST use ABSOLUTE path either in /tmp or /var/tmp, otherwise the tool won't work:

# cd /tmp
# katello-backup /tmp/bkp
# ls bkp

Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA.

For information on the advisory, and where to find the updated files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0336