Bug 1391062

Summary:	TripleO CLI shows misleading failure reason
Product:	Red Hat OpenStack	Reporter:	Marius Cornea <mcornea>
Component:	python-tripleoclient	Assignee:	RHOS Maint <rhos-maint>
Status:	CLOSED WONTFIX	QA Contact:	Arik Chernetsky <achernet>
Severity:	high	Docs Contact:
Priority:	high
Version:	10.0 (Newton)	CC:	aschultz, beth.white, dbecker, hbrock, jslagle, mburns, morazi, rhel-osp-director-maint
Target Milestone:	---	Keywords:	Triaged, ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-07-29 15:33:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Marius Cornea 2016-11-02 13:51:45 UTC

Description of problem:
TripleO CLI shows misleading failure reason:

Version-Release number of selected component (if applicable):
python-tripleoclient-5.3.0-3.el7ost.noarch
openstack-tripleo-common-5.3.0-3.el7ost.noarch

How reproducible:
100%

Steps to Reproduce:
source ~/stackrc
export THT=/usr/share/openstack-tripleo-heat-templates/

openstack overcloud deploy --debug --templates $THT \
-r ~/openstack_deployment/roles/roles_data.yaml \
-e $THT/environments/network-isolation.yaml \
-e $THT/environments/network-management.yaml \
-e $THT/environments/storage-environment.yaml \
-e ~/openstack_deployment/environments/nodes.yaml \
-e ~/openstack_deployment/environments/network-environment.yaml \
-e ~/openstack_deployment/environments/disk-layout.yaml \
-e ~/openstack_deployment/environments/wipe-disk-env.yaml \
-e ~/openstack_deployment/environments/neutron-settings.yaml \
-e ~/openstack_deployment/environments/custom_nova.yaml 

Fails with:
Removing the current plan files
Uploading new plan files
Started Mistral Workflow. Execution ID: dab7427d-c085-4896-96d5-734faa9e5754
Plan updated
Deploying templates in the directory /tmp/tripleoclient-DabX0N/tripleo-heat-templates
Specify --ntp-server as parameter or NtpServer in environments when using multiple controllers (with HA).

The DnsServers parameter does exist in the ~/openstack_deployment/environments/network-environment.yaml:
http://paste.openstack.org/show/587637/

Running the command with --debug we can see that the path for OS::TripleO::Keystone::Ports::StorageMgmtPort doesn't exist and it is the actual root cause of the issue:

Processing environment files /home/stack/openstack_deployment/environments/network-environment.yaml
Error Could not fetch contents for file:///usr/share/openstack-tripleo-heat-templates/network/ports/noop.yam processing environment file /home/stack/openstack_deployment/environments/network-environment.yaml

Actual results:
The deploy command fails with a misleading error message.

Expected results:
The deploy command shows the real cause of failure.