Bug 1391216

Koji EL6 build:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=16627151
    [?] has issues with old sphinx version :/
Koji EPEL7 build:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=16627104

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======
- Package contains BR: python2-devel or python3-devel
  => OK: calls python%{python3_pkgversion}-devel and is EPEL only package
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 1792000 bytes in 104 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
  [!] Probably should be in a doc package at this size?
- Additional licenses found (see attached licensecheck.txt)

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "GPL (v2 or later)", "Unknown or generated",
     "MIT/X11 (BSD like)", "BSD (3 clause)", "GPL (v2 or later) (with
     incorrect FSF address)", "BSD (2 clause)". 260 files have unknown
     license. Detailed output of licensecheck in
     /home/parallels/1391216-python3-pygments/licensecheck.txt
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/licenses
     => OK: there is no default owner for /usr/share/licenses in EPEL
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/licenses
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python34-pygments-2.1.3-1.el7.centos.noarch.rpm
          python3-pygments-2.1.3-1.el7.centos.src.rpm
python34-pygments.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pygments/lexers/__pycache__/rdf.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
<-- snip -->
python34-pygments.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pygments/lexers/__pycache__/grammar_notation.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
  => OK: this is due to a bug in rpmlint
2 packages and 0 specfiles checked; 360 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
python34-pygments.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pygments/lexers/__pycache__/rdf.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
<-- snip -->
python34-pygments.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pygments/lexers/__pycache__/grammar_notation.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
1 packages and 0 specfiles checked; 360 errors, 1 warnings.



Requires
--------
python34-pygments (rpmlib, GLIBC filtered):
    /usr/bin/python3.4
    python(abi)
    python34-setuptools



Provides
--------
python34-pygments:
    python34-pygments



Source checksums
----------------
http://pypi.python.org/packages/source/P/Pygments/Pygments-2.1.3.tar.gz :
  CHECKSUM(SHA256) this package     : 88e4c8a91b2af5962bfa5ea2447ec6dd357018e86e94c7d14bd8cacbc5b55d81
  CHECKSUM(SHA256) upstream package : 88e4c8a91b2af5962bfa5ea2447ec6dd357018e86e94c7d14bd8cacbc5b55d81


Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -b 1391216
Buildroot used: epel-7-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Created attachment 1224509 [details]
license check.txt

Additional licenses auto-detected in licensecheck.txt

Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-pygments.spec
SRPM URL: https://www.cora.nwra.com/~orion/fedora/python3-pygments-2.1.3-2.el7.src.rpm

* Tue Nov 29 2016 Orion Poplawski <orion.com> - 2.1.3-2
- Split documentation into sub-package
- Update license


tests aren't shipped so don't need to be included in the license.

Sorry, I let this slip off my radar. Latest version is now 2.2.0 from 1/27/2017.

Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-pygments.spec
SRPM URL: https://www.cora.nwra.com/~orion/fedora/python3-pygments-2.2.0-1.el7.src.rpm

* Tue Feb 28 2017 Orion Poplawski <orion.com> - 2.2.0-1
- Update to 2.2.0
- Put documentation into separate package

Differences from the original review:
[x]: License field in the package spec file matches the actual license.
(The additional Apache license for the robotframework.py is indicated, the remaining additional detected licenses are only for test files which are not packaged)
[x]: Latest version is packaged.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.

All review comments have been addressed.

APPROVED

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python3-pygments

python3-pygments-2.2.0-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-e470309e39

python3-pygments-2.2.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-e87d3004e5

python3-pygments-2.2.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-e87d3004e5

python3-pygments-2.2.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-e470309e39

python3-pygments-2.2.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

python3-pygments-2.2.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.