| Summary: | Review Request: perl-DBICx-AutoDoc - Generate automatic documentation of DBIx::Class::Schema objects | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Emmanuel Seyman <emmanuel> |
| Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jplesnik, package-review |
| Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-04 14:03:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Emmanuel Seyman
2016-11-02 23:53:54 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires
FIX: Please add following build-requires:
make - spec file lines: 41, 44, 48
perl(base) - lib/DBICx/AutoDoc.pm:5
perl(DBIx::Class::Relationship::Helpers) - lib/DBICx/AutoDoc/Magic.pm:5
perl(File::Spec) - lib/DBICx/AutoDoc.pm:13
perl(FindBin) - lib/DBICx/AutoDoc.pm:8
perl(strict) - lib/DBICx/AutoDoc.pm:2
perl(warnings) - lib/DBICx/AutoDoc.pm:3
FIX: Either unbundle the ./inc files and build-require the Module::Install*
modules whose functions are called from Makefile.PL or build-require
dependencies of the bundled code (`perl(File::Find)' in
inc/Module/Install.pm:23, `perl(File::Path)' in inc/Module/Install.pm:24 etc.).
$ rpm -qp --requires perl-DBICx-AutoDoc-0.08-2.fc26.noarch.rpm | sort | uniq -c
1 /usr/bin/perl
1 perl(:MODULE_COMPAT_5.24.0)
1 perl(Carp)
1 perl(Class::Accessor::Grouped)
1 perl(DBICx::AutoDoc)
1 perl(DBICx::AutoDoc::Magic)
1 perl(DBIx::Class)
1 perl(DBIx::Class::Relationship::Helpers)
1 perl(Data::Dump)
1 perl(File::ShareDir)
1 perl(File::Spec)
1 perl(File::Temp)
1 perl(FindBin)
1 perl(Getopt::Long)
1 perl(Pod::Usage)
1 perl(Template)
1 perl(Tie::IxHash)
1 perl(base)
1 perl(lib)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -qp --provides perl-DBICx-AutoDoc-0.08-2.fc26.noarch.rpm | sort | uniq -c
1 perl(DBICx::AutoDoc) = 0.08
1 perl(DBICx::AutoDoc::Magic) = 0.08
1 perl-DBICx-AutoDoc = 0.08-2.fc26
Binary provides are Ok.
$ rpmlint ./perl-DBICx-AutoDoc*
perl-DBICx-AutoDoc.noarch: W: spelling-error %description -l en_US schemas -> schema, sachems, schemes
perl-DBICx-AutoDoc.noarch: E: wrong-script-interpreter /usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-inheritance.png [% ENV.SHELL %]
perl-DBICx-AutoDoc.noarch: E: non-executable-script /usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-inheritance.png 644 [% ENV.SHELL %]
perl-DBICx-AutoDoc.noarch: E: wrong-script-interpreter /usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-graph.png [% ENV.SHELL %]
perl-DBICx-AutoDoc.noarch: E: non-executable-script /usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-graph.png 644 [% ENV.SHELL %]
perl-DBICx-AutoDoc.noarch: E: non-executable-script /usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-inheritance.html 644 /usr/bin/perl
perl-DBICx-AutoDoc.noarch: E: non-executable-script /usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-graph.html 644 /usr/bin/perl
perl-DBICx-AutoDoc.src: W: spelling-error %description -l en_US schemas -> schema, sachems, schemes
2 packages and 1 specfiles checked; 6 errors, 2 warnings.
*.html and *.png are not scripts. The errors are not valid.
Rpmlint is ok.
Please correct all 'FIX' issues and provide new spec file.
The package is not approved.
(In reply to Jitka Plesnikova from comment #1) > > FIX: Please add following build-requires: > make - spec file lines: 41, 44, 48 > perl(base) - lib/DBICx/AutoDoc.pm:5 > perl(DBIx::Class::Relationship::Helpers) - lib/DBICx/AutoDoc/Magic.pm:5 > perl(File::Spec) - lib/DBICx/AutoDoc.pm:13 > perl(FindBin) - lib/DBICx/AutoDoc.pm:8 > perl(strict) - lib/DBICx/AutoDoc.pm:2 > perl(warnings) - lib/DBICx/AutoDoc.pm:3 Added. > FIX: Either unbundle the ./inc files and build-require the Module::Install* > modules whose functions are called from Makefile.PL or build-require > dependencies of the bundled code (`perl(File::Find)' in > inc/Module/Install.pm:23, `perl(File::Path)' in > inc/Module/Install.pm:24 etc.). I've unbundled and build-required the necessary files. > Please correct all 'FIX' issues and provide new spec file. Spec URL: http://people.parinux.org/~seyman/fedora/perl-DBICx-AutoDoc/perl-DBICx-AutoDoc.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-DBICx-AutoDoc/perl-DBICx-AutoDoc-0.08-3.fc24.src.rpm Everything is ok. Tha package is approved. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-DBICx-AutoDoc I've imported the package, built it and released updates for f25 and f24. Thank you for the review, Jitka. |