Bug 1391451

Summary:	md-cache: Invalidate cache entry in case of OPEN with O_TRUNC
Product:	[Community] GlusterFS	Reporter:	Soumya Koduri <skoduri>
Component:	md-cache	Assignee:	Soumya Koduri <skoduri>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.7.15	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.7.18	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1382266	Environment:
Last Closed:	2016-12-13 07:19:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1382266
Bug Blocks:	1381968, 1391448, 1391450

Description Soumya Koduri 2016-11-03 11:00:25 UTC

+++ This bug was initially created as a clone of Bug #1382266 +++

Description of problem:

In case if there is open() done on a file with O_TRUNC posix flag passed, the backend server truncates the file, resulting in change of size of the file. This case needs to be handled by md-cache and should invalidate its cache-entry accordingly.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-10-06 03:47:11 EDT ---

REVIEW: http://review.gluster.org/15618 (md-cache: Invalidate cache entry for open() with O_TRUNC) posted (#1) for review on master by soumya k (skoduri)

--- Additional comment from Worker Ant on 2016-10-10 09:12:30 EDT ---

REVIEW: http://review.gluster.org/15618 (md-cache: Invalidate cache entry for open() with O_TRUNC) posted (#2) for review on master by soumya k (skoduri)

--- Additional comment from Worker Ant on 2016-10-10 09:48:39 EDT ---

REVIEW: http://review.gluster.org/15618 (md-cache: Invalidate cache entry for open() with O_TRUNC) posted (#3) for review on master by soumya k (skoduri)

--- Additional comment from Worker Ant on 2016-10-14 06:46:40 EDT ---

REVIEW: http://review.gluster.org/15618 (md-cache: Invalidate cache entry for open() with O_TRUNC) posted (#4) for review on master by soumya k (skoduri)

--- Additional comment from Worker Ant on 2016-10-27 01:46:36 EDT ---

COMMIT: http://review.gluster.org/15618 committed in master by Raghavendra G (rgowdapp) 
------
commit 6ca5d6382f03685b31b12accb095093cf1486603
Author: Soumya Koduri <skoduri>
Date:   Thu Oct 6 13:13:44 2016 +0530

    md-cache: Invalidate cache entry for open() with O_TRUNC
    
    When a file is opened with O_TRUNC flag set, its size gets
    set to '0'. This case needs to be handled in md-cache to
    avoid sending incorrect cached stat.
    
    Change-Id: I95d1f8a6634734898883ede010c3e7b0b7eb97d9
    BUG: 1382266
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: http://review.gluster.org/15618
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: jiffin tony Thottan <jthottan>
    Tested-by: jiffin tony Thottan <jthottan>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 1 Worker Ant 2016-11-04 06:05:26 UTC

REVIEW: http://review.gluster.org/15772 (md-cache: Invalidate cache entry for open() with O_TRUNC) posted (#2) for review on release-3.7 by soumya k (skoduri)

Comment 2 Worker Ant 2016-11-04 10:10:40 UTC

COMMIT: http://review.gluster.org/15772 committed in release-3.7 by Kaleb KEITHLEY (kkeithle) 
------
commit f9ed9b87b74fa5868187f3743d04d105b921c510
Author: Soumya Koduri <skoduri>
Date:   Thu Oct 6 13:13:44 2016 +0530

    md-cache: Invalidate cache entry for open() with O_TRUNC
    
    When a file is opened with O_TRUNC flag set, its size gets
    set to '0'. This case needs to be handled in md-cache to
    avoid sending incorrect cached stat.
    
    This is backport of below mainline patch -
    http://review.gluster.org/#/c/15618/
    
    > Change-Id: I95d1f8a6634734898883ede010c3e7b0b7eb97d9
    > BUG: 1382266
    > Signed-off-by: Soumya Koduri <skoduri>
    > Reviewed-on: http://review.gluster.org/15618
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: jiffin tony Thottan <jthottan>
    > Tested-by: jiffin tony Thottan <jthottan>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle>
    > (cherry picked from commit 6ca5d6382f03685b31b12accb095093cf1486603)
    
    Change-Id: I00d2b0a6dbafa690235bbc7cd714ec7cc8a13808
    BUG: 1391451
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: http://review.gluster.org/15772
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 3 Kaushal 2016-12-13 07:19:35 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.18, please open a new bug report.

glusterfs-3.7.18 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-December/029427.html
[2] https://www.gluster.org/pipermail/gluster-users/