Bug 1391541

Summary:	[CFME 5.7 Beta] Refreshing a git automate domain from a new tag does not update the method code
Product:	Red Hat CloudForms Management Engine	Reporter:	Peter McGowan <pmcgowan>
Component:	Automate	Assignee:	mkanoor
Status:	CLOSED CURRENTRELEASE	QA Contact:	Dmitry Misharov <dmisharo>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.7.0	CC:	cpelland, gmccullo, jhardy, mkanoor, obarenbo, tfitzger
Target Milestone:	GA	Keywords:	TestOnly
Target Release:	5.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	automate:git
Fixed In Version:	5.8.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1392969 (view as bug list)		Environment:
Last Closed:	2017-06-12 16:06:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1392969

Description Peter McGowan 2016-11-03 13:56:32 UTC

Description of problem:
If I have a Git-synchronized automate domain, the method code does not update when I run Configuration -> Refresh with a new branch or tag, and pick a different tag.

Version-Release number of selected component (if applicable):
5.7.0.9-beta2.

How reproducible:
Every time

Steps to Reproduce:
1. Import an automate domain from git (I used https://github.com/pemcg/object_walker as an example)
2. Select a tag to import (say v1.9), allow domain to be created successfully
3. In automate explorer, click on new domain and click Configuration -> Refresh with a new branch or tag. Pick a different tag.
4. Observe the message "Successfully refreshed!", and the title of the domain change to reflect the new tag name. Note that the method code has not changed, it is still the code from the old tag.
5. If you delete the domain and re-import from the alternative tag, the method code is correct.

Comment 2 CFME Bot 2016-11-03 20:16:40 UTC

https://github.com/ManageIQ/manageiq/pull/12425

Comment 3 CFME Bot 2016-11-07 23:16:29 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/cb89c52ae8096fd7e4eefc007c486e8659b80fae

commit cb89c52ae8096fd7e4eefc007c486e8659b80fae
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Thu Nov 3 16:01:12 2016 -0400
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Thu Nov 3 16:02:54 2016 -0400

    During Refresh route calls to the correct appliance
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1391541

 app/controllers/miq_ae_class_controller.rb         |  4 ++
 app/services/git_based_domain_import_service.rb    | 33 ++++++++++-
 .../git_based_domain_import_service_spec.rb        | 67 +++++++++++++++++++++-
 3 files changed, 100 insertions(+), 4 deletions(-)

Comment 4 CFME Bot 2016-11-07 23:26:15 UTC

New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/b7e11a09f5defe34752716c43650645a1bc04c66

commit b7e11a09f5defe34752716c43650645a1bc04c66
Author:     Greg McCullough <gmccullo>
AuthorDate: Mon Nov 7 18:15:19 2016 -0500
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Mon Nov 7 18:17:59 2016 -0500

    Merge pull request #12425 from mkanoor/route_refresh_thru_queue
    
    During Refresh route calls to the correct appliance
    (cherry picked from commit b22e6b6a4afa5cc5ec396002efaf1891b3c1f8d7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1391541

 app/controllers/miq_ae_class_controller.rb         |  4 ++
 app/services/git_based_domain_import_service.rb    | 31 +++++++++-
 .../git_based_domain_import_service_spec.rb        | 67 +++++++++++++++++++++-
 3 files changed, 98 insertions(+), 4 deletions(-)

Comment 6 Milan Falešník 2017-02-28 13:57:49 UTC

Verified in 5.8.0.2. When I selected a newer tag, it correctly updated the method.