Bug 1391618

Summary: preupg-xccdf-compose does incorrect modifications to script *header*
Product: Red Hat Enterprise Linux 6 Reporter: Petr Stodulka <pstodulk>
Component: preupgrade-assistantAssignee: Michal Bocek <mbocek>
Status: CLOSED WONTFIX QA Contact: Alois Mahdal <amahdal>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.9CC: phracek, pstodulk
Target Milestone: rcKeywords: Extras
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-01 15:50:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1391649    

Description Petr Stodulka 2016-11-03 15:53:15 UTC 
Description of problem:
Similarly to bug #1362762, placeholder is removed, but now in case that author exists in INI file but it is empty (see below).

After discussion, the much better will be new concept of *building* of modules,
without any modifications in script files during building. Instead of including
some lines into check scripts, P-A itself should handle this before run
of the script; with same result as lines are included in scripts
(sorry for rugged sentence, hope the idea is clear).

In that way, probably we could ignore the "author" key completely.

Version-Release number of selected component (if applicable):
preupgrade-assistant-2.1.10


Steps to Reproduce:
Set author of a module to empty string. INI file could seems like this:
[preupgrade]
content_title       = foo title
content_description = foo description
author       =          
solution     = solution.txt
check_script = check.sh 


Actual results:
Placebolder in check script is removed and module doesn't work.


Expected results:
Module will not be broken after *build* by preupgr-xccdf-compose.
Comment 2 Michal Bocek 2019-07-01 15:50:59 UTC 
Closing this bugzilla as the component is under a maintenance mode in which the maintainers are going to fix only critical bugs. If you consider the bugzilla critical, feel free to reopen the bug with an explanation.