| Summary: | [TestOnly] Verify compatibility with python-paramiko 2.0 | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Sandro Bonazzola <sbonazzo> |
| Component: | Setup.Core | Assignee: | Yedidyah Bar David <didi> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Pavol Brilla <pbrilla> |
| Severity: | urgent | Docs Contact: | |
| Priority: | urgent | ||
| Version: | 4.1.0 | CC: | bugs, didi, pbrilla, sbonazzo, ylavi |
| Target Milestone: | ovirt-4.1.6 | Keywords: | FutureFeature, TestOnly |
| Target Release: | 4.1.5.2 | Flags: | sbonazzo:
ovirt-4.1?
sbonazzo: blocker? sbonazzo: planning_ack? sbonazzo: devel_ack+ pstehlik: testing_ack+ |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Rebase: Bug Fixes and Enhancements | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-09-19 10:02:45 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Sandro Bonazzola
2016-11-04 10:39:18 UTC
Re-adding to 4.2 as urgent. python-paramiko-2.1.1-2.el7 has been added to RHEL 7.4 extra as dependency for ansible 2.3.1. extra repository is enabled by default in CentOS so it will break oVirt as soon as CentOS 7.4 will be released. Retargeted to 4.1.6 since it will be hit as well. Not sure why this is a CodeChange. Now tested this flow: 1. Setup 4.1 engine on machine A 2. Install on machine B: - dwh setup plugin - websocket-proxy setup plugin - python-paramiko-2.1.1 3. Run on machine B engine-setup, accept most defaults (configure dwh, websocket-proxy, ssh as root for access to the engine machine) Everything seems to work well. Anything else? Do we know about any reason why it should not work? Didn't check the release notes or anything else about the difference between paramiko 1 and 2. IMO we can remove CodeChange and add TestOnly (and move to QE). Also, do we want to _require_ newer paramiko (as opposed to simply make sure it works, but use whatever that's available)? Also, now gave a brief look at the changelog, and at least in 2.0.0 it moved from PyCrypto to pyCA, stating this affects only installation, with no API changes intended or expected: http://www.paramiko.org/changelog.html#2.0.0 Thanks for the analysis, moving to test only. I need also erratum, so we will add this python-paramiko from extras channel to ours (In reply to Pavol Brilla from comment #6) > I need also erratum, so we will add this python-paramiko from extras channel > to ours To clarify: No code change was needed. Our code works with both 1 and 2. We do not (currently) need specific features from 2. We are not going to require it, so no need to handle errata, shipping, etc. - just to verify that if it's installed, everything works. See comment 3 for a relevant flow, that covers at least parts of the code that uses paramiko. Changed Summary and Keywords accordingly. tested clean engine-setup with: # yum list python-paramiko Loaded plugins: product-id, search-disabled-repos, versionlock Installed Packages python-paramiko.noarch 2.1.1-2.el7 all - dwh engine websocket succesfull (In reply to Pavol Brilla from comment #8) > tested clean engine-setup with: > > # yum list python-paramiko > Loaded plugins: product-id, search-disabled-repos, versionlock > Installed Packages > python-paramiko.noarch > 2.1.1-2.el7 > > all - dwh engine websocket succesfull paramiko is not used if all are on a single machine. paramiko is the python library we use to do ssh inside setup, in case you setup some parts on separate machines and choose to use ssh as root to configure the engine machine. See comment 3 for a relevant flow. And BTW, it would a good idea to verify this flow, having some components on separate machines, for every release, even if there isn't a specific bug about it. Cleaning info, yes it was tested also on dwh on separate machine |