| Summary: | Haproxy systemd wrapper reports wrong exit codes to systemd | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Gabriele Cerami <gcerami> | |
| Component: | haproxy | Assignee: | Ryan O'Hara <rohara> | |
| Status: | CLOSED ERRATA | QA Contact: | Brandon Perkins <bperkins> | |
| Severity: | urgent | Docs Contact: | ||
| Priority: | urgent | |||
| Version: | 7.0 | CC: | cfeist, fdinitto, michele, rohara, toneata, ushkalim, vcojot | |
| Target Milestone: | rc | Keywords: | ZStream | |
| Target Release: | --- | Flags: | toneata:
needinfo?
(rohara) |
|
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | haproxy-1.5.18-4.el7 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1396219 1500968 1500969 1501527 (view as bug list) | Environment: | ||
| Last Closed: | 2017-08-01 21:31:54 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Bug Depends On: | ||||
| Bug Blocks: | 1396219, 1500968, 1500969, 1501527 | |||
|
Description
Gabriele Cerami
2016-11-04 14:34:58 UTC
Bug was already discussed with upstream here: https://www.mail-archive.com/haproxy@formilux.org/msg23896.html Upstream released a patch here: http://git.haproxy.org/?p=haproxy.git;a=commit;h=f7659cb10cb0420c7ca06fad1067207021d2a078 That should also be backported to 1.5 and 1.6 versions (In reply to Gabriele Cerami from comment #1) > Bug was already discussed with upstream here: > > https://www.mail-archive.com/haproxy@formilux.org/msg23896.html > > Upstream released a patch here: > > http://git.haproxy.org/?p=haproxy.git;a=commit; > h=f7659cb10cb0420c7ca06fad1067207021d2a078 > > That should also be backported to 1.5 and 1.6 versions We don't distribute version 1.6 in RHEL7. Did you try the latest version (1.5.18) in brew? That rebase will be release in RHEL7.3. I will check to see if that backport is in 1.5.18 on Monday. Else this will have to wait for RHEL7.4 unless you can get the acks needed to get this into RHEL7.3. > > That should also be backported to 1.5 and 1.6 versions > > We don't distribute version 1.6 in RHEL7. Sorry, what I meant was that the fix was in place for upstream release 1.7, and should be backported soon to 1.6 and 1.5 upstream, so it may take a while to actually land in 1.5 in upstream. > Did you try the latest version (1.5.18) in brew? That rebase will be release > in RHEL7.3. I will check to see if that backport is in 1.5.18 on Monday. > Else this will have to wait for RHEL7.4 unless you can get the acks needed > to get this into RHEL7.3. 1.5.18 was tagged 5 months ago, and last changelog entry is from 21 Oct. So, no patch for this, and as I'm saying above, it may take a while to get into 1.5.(maybe)19 at this point. We'll probably have to wait 7.4 Patch backported and applied to source. With patch in place and haproxy configured to have a frontend that listens on port 80 (bind *:80 in this case), start httpd such that haproxy will fail to start due to the port already being used: # systemctl start httpd # /usr/sbin/haproxy-systemd-wrapper -f /etc/haproxy/haproxy.cfg -p /run/haproxy.pid <7>haproxy-systemd-wrapper: executing /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -p /run/haproxy.pid -Ds [ALERT] 320/221723 (63474) : Starting frontend mesa_vip: cannot bind socket [0.0.0.0:80] <5>haproxy-systemd-wrapper: exit, haproxy RC=1 # echo $? 1 Previously, the "echo $?" would return 0 in this case. Verifed on haproxy-1.5.18-4.el7.x86_64 [root@controller-2 ~]# rpm -qa | grep haprox haproxy-1.5.18-4.el7.x86_64 puppet-haproxy-1.5.0-0.20170210185359.f6fed46.el7ost.noarch [root@controller-2 ~]# nc -l 8080 & [2] 222947 [root@controller-2 ~]# /usr/sbin/haproxy-systemd-wrapper -f /etc/haproxy/haproxy.cfg -p /run/haproxy.pid <7>haproxy-systemd-wrapper: executing /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -p /run/haproxy.pid -Ds [ALERT] 084/104235 (222967) : Starting proxy swift_proxy_server: cannot bind socket [10.0.0.102:8080] [ALERT] 084/104235 (222967) : Starting proxy swift_proxy_server: cannot bind socket [172.17.3.11:8080] <5>haproxy-systemd-wrapper: exit, haproxy RC=1 [root@controller-2 ~]# echo $? 1 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:2170 |