Bug 1392308

Summary: metrics-heapster crash when get version
Product: OpenShift Container Platform Reporter: DeShuai Ma <dma>
Component: HawkularAssignee: Matt Wringe <mwringe>
Status: CLOSED NOTABUG QA Contact: Peng Li <penli>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.4.0CC: aos-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-07 14:43:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description DeShuai Ma 2016-11-07 07:29:52 UTC
Description of problem:
when get heapster version using latest metrics-heapster image, heapster crash with error.
This should be a bug in upstream v1.2.0, now our metrics-heapster version is v1.2.0 too.

Version-Release number of selected component (if applicable):
openshift v3.4.0.22+5c56720
brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/metrics-heapster:3.4.0
image id: e4c76b3a21e9

How reproducible:
Always

Steps to Reproduce:
1. [root@openshift-143 ~]# docker run -it --entrypoint=/bin/sh brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/metrics-heapster:3.4.0
    sh-4.2# /bin/heapster version
    F1107 01:44:29.968841       5 heapster.go:77] Wrong number of sources specified
    goroutine 1 [running]:
    k8s.io/heapster/vendor/github.com/golang/glog.stacks(0x3556f00, 0x0, 0x0, 0x0)
            /builddir/build/BUILD/heapster-1.2.0/_build/src/k8s.io/heapster/vendor/github.com/golang/glog/glog.go:766 +0xb8
    k8s.io/heapster/vendor/github.com/golang/glog.(*loggingT).output(0x3536c00, 0xc800000003, 0xc8200be0c0, 0x35022af, 0xb, 0x4d, 0x0)
            /builddir/build/BUILD/heapster-1.2.0/_build/src/k8s.io/heapster/vendor/github.com/golang/glog/glog.go:717 +0x259
    k8s.io/heapster/vendor/github.com/golang/glog.(*loggingT).printDepth(0x3536c00, 0x3, 0x1, 0xc8204afd90, 0x1, 0x1)
            /builddir/build/BUILD/heapster-1.2.0/_build/src/k8s.io/heapster/vendor/github.com/golang/glog/glog.go:646 +0x1b8
    k8s.io/heapster/vendor/github.com/golang/glog.(*loggingT).print(0x3536c00, 0x3, 0xc8204afd90, 0x1, 0x1)
            /builddir/build/BUILD/heapster-1.2.0/_build/src/k8s.io/heapster/vendor/github.com/golang/glog/glog.go:637 +0x50
    k8s.io/heapster/vendor/github.com/golang/glog.Fatal(0xc8204afd90, 0x1, 0x1)
            /builddir/build/BUILD/heapster-1.2.0/_build/src/k8s.io/heapster/vendor/github.com/golang/glog/glog.go:1125 +0x49
    main.main()
            /builddir/build/BUILD/heapster-1.2.0/_build/src/k8s.io/heapster/metrics/heapster.go:77 +0x48f

Actual results:

Expected results:
1.Get heapster version correctly.

Additional info:
In latest heapster upstream get version corectly:
[root@ip-172-18-6-200 heapster]# ./heapster version
I1107 01:45:29.756144    5553 heapster.go:65] ./heapster version
I1107 01:45:29.756344    5553 heapster.go:66] Heapster version 1.2.0

Comment 1 DeShuai Ma 2016-11-07 07:45:32 UTC
We can fix this bug in upstream v1.2.0 then rebuild our metrics-heapster image.

Comment 2 DeShuai Ma 2016-11-07 09:36:18 UTC
Create a upstream issue: https://github.com/kubernetes/heapster/issues/1370

Comment 3 Matt Wringe 2016-11-07 14:43:14 UTC
There is no 'heapster version' command.

Running this both in 1.2.0 and master results in an error message that Heapster could not start, the only difference is the error message being returned (and it seems that master does handle this a bit better).