Bug 1392366

Summary:	trashcan max file limit cannot go beyond 1GB
Product:	[Community] GlusterFS	Reporter:	Anoop C S <anoopcs>
Component:	trash-xlator	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.7.0	CC:	anoopcs, bugs, jackie, jthottan
Target Milestone:	---	Keywords:	EasyFix, Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.7.18	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1386766	Environment:
Last Closed:	2016-12-13 07:20:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1386766
Bug Blocks:	1392363, 1392364, 1393282

Description Anoop C S 2016-11-07 10:21:35 UTC

+++ This bug was initially created as a clone of Bug #1386766 +++

Description of problem:

max file size supported by trashcan feature is hardcoded to 1GB.  For admins who manage volumes where only larger files are stored, this heavily erodes the value of the trashcan feature.  it would be nice to either not have this limit, or have an override option.


Version-Release number of selected component (if applicable):
all versions with trashcan I believe.  I am using 3.8 myself.

How reproducible:
trivial, it was a feature, not a bug.

Steps to Reproduce:
1. enable trashcan
2. increase limit to something above 1GB
3. delete a large file (larger than 1GB)

Actual results:
large file deleted permanently, bypassing trashcan

Desired (by me at least!) results:
large file goes to trashcan

Additional info:

--- Additional comment from Worker Ant on 2016-10-21 00:13:57 IST ---

REVIEW: http://review.gluster.org/15689 (xlators/trash : Remove upper limit for trash max file size) posted (#1) for review on master by jiffin tony Thottan (jthottan)

--- Additional comment from Worker Ant on 2016-11-03 19:39:47 IST ---

COMMIT: http://review.gluster.org/15689 committed in master by Vijay Bellur (vbellur) 
------
commit cd9be49f6fe05d424989c0686a7e55a3f3ead27e
Author: Jiffin Tony Thottan <jthottan>
Date:   Fri Oct 21 00:08:26 2016 +0530

    xlators/trash : Remove upper limit for trash max file size
    
    Currently file which size exceeds more than 1GB never moved to
    trash directory. This is due to the hard coded check using
    GF_ALLOWED_MAX_FILE_SIZE.
    
    Change-Id: I2ed707bfe1c3114818896bb27a9856b9a164be92
    BUG: 1386766
    Signed-off-by: Jiffin Tony Thottan <jthottan>
    Reviewed-on: http://review.gluster.org/15689
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Anoop C S <anoopcs>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 1 Worker Ant 2016-11-07 10:30:01 UTC

REVIEW: http://review.gluster.org/15786 (xlators/trash : Remove upper limit for trash max file size) posted (#1) for review on release-3.7 by jiffin tony Thottan (jthottan)

Comment 2 Worker Ant 2016-11-28 12:28:01 UTC

COMMIT: http://review.gluster.org/15786 committed in release-3.7 by Niels de Vos (ndevos) 
------
commit 285987ab9ed968a37df1bada56f137579146a23f
Author: Jiffin Tony Thottan <jthottan>
Date:   Fri Oct 21 00:08:26 2016 +0530

    xlators/trash : Remove upper limit for trash max file size
    
    Currently file which size exceeds more than 1GB never moved to
    trash directory. This is due to the hard coded check using
    GF_ALLOWED_MAX_FILE_SIZE.
    
    Upstream reference :
    >Change-Id: I2ed707bfe1c3114818896bb27a9856b9a164be92
    >BUG: 1386766
    >Signed-off-by: Jiffin Tony Thottan <jthottan>
    >Reviewed-on: http://review.gluster.org/15689
    >Smoke: Gluster Build System <jenkins.org>
    >Reviewed-by: Anoop C S <anoopcs>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >Reviewed-by: Vijay Bellur <vbellur>
    >(cherry picked from commit cd9be49f6fe05d424989c0686a7e55a3f3ead27e)
    
    Change-Id: I2ed707bfe1c3114818896bb27a9856b9a164be92
    BUG: 1392366
    Signed-off-by: Jiffin Tony Thottan <jthottan>
    Reviewed-on: http://review.gluster.org/15786
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Anoop C S <anoopcs>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Kaushal 2016-12-13 07:20:01 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.18, please open a new bug report.

glusterfs-3.7.18 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-December/029427.html
[2] https://www.gluster.org/pipermail/gluster-users/