Bug 1392388

Summary: Review Request: perl-Geo-Distance - Calculate distances and closest locations
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Geo-Distance-0.20-1.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-07 16:02:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2016-11-07 11:47:12 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Geo-Distance/perl-Geo-Distance.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Geo-Distance/perl-Geo-Distance-0.20-1.fc26.src.rpm
Description:
This Perl library aims to provide as many tools to make it as simple as
possible to calculate distances between geographic points, and anything
that can be derived from that. Currently there is support for finding the
closest locations within a specified distance, to find the closest number
of points to a specified point, and to do basic point-to-point distance
calculations.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-11-07 12:29:10 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Geo-Distance-0.20-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Carp)
      1 perl(Math::Trig)
      1 perl(constant)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Geo-Distance-0.20-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(Geo::Distance) = 0.20
      1 perl-Geo-Distance = 0.20-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Geo-Distance*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2016-11-07 14:48:22 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Geo-Distance

Comment 3 Petr Pisar 2016-11-07 16:02:45 UTC
Thank you for the review and the repository.