Bug 1392434

Summary: Review Request: perl-XML-LibXML-Devel-SetLineNumber - Set the line number for an XML::LibXML::Node
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-XML-LibXML-Devel-SetLineNumber-0.002-1.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-08 09:17:16 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1392451    

Description Petr Pisar 2016-11-07 13:53:13 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-XML-LibXML-Devel-SetLineNumber/perl-XML-LibXML-Devel-SetLineNumber.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-XML-LibXML-Devel-SetLineNumber/perl-XML-LibXML-Devel-SetLineNumber-0.002-1.fc26.src.rpm
Description:
If you are, say, writing a parser for a non-XML format that happens to have an
XML-like data model, then you might wish to parse your format into an
XML::LibXML document with elements, attributes and so on. And you might want
all those nodes to return the correct line numbers when the "line_number"
method is called on them. This Perl module allows you to set the line number.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2016-11-07 15:22:41 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-XML-LibXML-Devel-SetLineNumber-0.002-1.fc26.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libdl.so.2()(64bit)
      1 libm.so.6()(64bit)
      1 libperl.so.5.24()(64bit)
      1 libxml2.so.2()(64bit)
      1 libxml2.so.2(LIBXML2_2.4.30)(64bit)
      1 libz.so.1()(64bit)
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.8.3
      1 perl(Exporter)
      1 perl(XML::LibXML) >= 1.90
      1 perl(XML::LibXML::Devel)
      1 perl(XSLoader)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-XML-LibXML-Devel-SetLineNumber-0.002-1.fc26.x86_64.rpm | sort | uniq -c
      1 perl(XML::LibXML::Devel::SetLineNumber) = 0.002
      1 perl-XML-LibXML-Devel-SetLineNumber = 0.002-1.fc26
      1 perl-XML-LibXML-Devel-SetLineNumber(x86-64) = 0.002-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-XML-LibXML-Devel-SetLineNumber*
perl-XML-LibXML-Devel-SetLineNumber.src: W: invalid-license (GPL+
perl-XML-LibXML-Devel-SetLineNumber.src: W: invalid-license Artistic
perl-XML-LibXML-Devel-SetLineNumber.src: W: invalid-license CC-BY-SA)
perl-XML-LibXML-Devel-SetLineNumber.x86_64: W: invalid-license (GPL+
perl-XML-LibXML-Devel-SetLineNumber.x86_64: W: invalid-license Artistic
perl-XML-LibXML-Devel-SetLineNumber.x86_64: W: invalid-license CC-BY-SA)
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

The license is valid. It seems that rpmlint did not properly process '((GPL+ or Artistic) or CC-BY-SA)'.
Rpmlint is ok

The package looks good.
Approved.
Comment 2 Gwyn Ciesla 2016-11-07 16:09:53 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-XML-LibXML-Devel-SetLineNumber
Comment 3 Petr Pisar 2016-11-08 09:17:16 UTC 
Thank you for the review and the repository.