Bug 1392451

Summary: Review Request: perl-HTML-HTML5-Parser - Parse HTML reliably
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-HTML-HTML5-Parser-0.301-1.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-08 14:37:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1392434    
Bug Blocks:    

Description Petr Pisar 2016-11-07 14:22:09 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-HTML-HTML5-Parser/perl-HTML-HTML5-Parser.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-HTML-HTML5-Parser/perl-HTML-HTML5-Parser-0.301-1.fc26.src.rpm
Description:
HTML parser with XML::LibXML-like DOM interface.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2016-11-08 13:57:09 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-HTML-HTML5-Parser-0.301-1.fc26.noarch.rpm | sort | uniq -c
      1 /usr/bin/perl
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.10.0
      1 perl(:VERSION) >= 5.8.1
      1 perl(Carp)
      1 perl(Data::Dumper)
      1 perl(Encode)
      1 perl(Encode::Encoding)
      1 perl(Exporter)
      1 perl(Getopt::Long)
      1 perl(HTML::HTML5::Entities) >= 0.002
      1 perl(HTML::HTML5::Parser)
      1 perl(HTML::HTML5::Parser::Charset::Info)
      1 perl(HTML::HTML5::Parser::Error)
      1 perl(HTML::HTML5::Parser::TagSoupParser)
      1 perl(HTML::HTML5::Parser::Tokenizer)
      1 perl(HTTP::Tiny)
      1 perl(IO::HTML)
      1 perl(IO::Handle)
      1 perl(Scalar::Util)
      1 perl(Try::Tiny)
      1 perl(URI::file)
      1 perl(XML::LibXML) >= 1.94
      1 perl(XML::LibXML::Devel)
      1 perl(overload)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-HTML-HTML5-Parser-0.301-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(HTML::HTML5::Parser) = 0.301
      1 perl(HTML::HTML5::Parser::Charset::DecodeHandle) = 0.301
      1 perl(HTML::HTML5::Parser::Charset::DecodeHandle::ByteBuffer)
      1 perl(HTML::HTML5::Parser::Charset::DecodeHandle::CharString)
      1 perl(HTML::HTML5::Parser::Charset::DecodeHandle::Encode)
      1 perl(HTML::HTML5::Parser::Charset::DecodeHandle::ISO2022JP)
      1 perl(HTML::HTML5::Parser::Charset::Info) = 0.301
      1 perl(HTML::HTML5::Parser::Charset::USASCII)
      1 perl(HTML::HTML5::Parser::Charset::UnicodeChecker) = 0.301
      1 perl(HTML::HTML5::Parser::Charset::UniversalCharDet) = 0.301
      1 perl(HTML::HTML5::Parser::Charset::WebLatin1) = 0.301
      1 perl(HTML::HTML5::Parser::Charset::WebLatin5)
      1 perl(HTML::HTML5::Parser::Charset::WebThai) = 0.301
      1 perl(HTML::HTML5::Parser::Charset::WebThai::WebTIS620)
      1 perl(HTML::HTML5::Parser::Error) = 0.301
      1 perl(HTML::HTML5::Parser::TagSoupParser)
      1 perl(HTML::HTML5::Parser::TagSoupParser) = 0.301
      1 perl(HTML::HTML5::Parser::TagSoupParser::RestartParser)
      1 perl(HTML::HTML5::Parser::Tokenizer) = 0.301
      1 perl(HTML::HTML5::Parser::UA) = 0.301
      1 perl-HTML-HTML5-Parser = 0.301-1.fc26
Binary provides are Ok.

TODO: Unversioned provide perl(HTML::HTML5::Parser::TagSoupParser) can be filtered.

$ rpmlint ./perl-HTML-HTML5-Parser*
perl-HTML-HTML5-Parser.noarch: W: spelling-error %description -l en_US LibXML -> Lib XML, Lib-XML, Librium
perl-HTML-HTML5-Parser.noarch: E: useless-provides perl(HTML::HTML5::Parser::TagSoupParser)
perl-HTML-HTML5-Parser.noarch: W: no-manual-page-for-binary html2xhtml
perl-HTML-HTML5-Parser.noarch: W: no-manual-page-for-binary html5debug
perl-HTML-HTML5-Parser.src: W: spelling-error %description -l en_US LibXML -> Lib XML, Lib-XML, Librium
2 packages and 1 specfiles checked; 1 errors, 4 warnings.

perl(HTML::HTML5::Parser::TagSoupParser) is declare in these two files
HTML-HTML5-Parser-0.301/lib/HTML/HTML5/Parser/Tokenizer.pm
HTML-HTML5-Parser-0.301/lib/HTML/HTML5/Parser/TagSoupParser.pm
It should be provided only once. 

Otherwise, rpmlint is ok

Please consider fixing 'TODO' item.

The package looks good.
Approved.
Comment 2 Gwyn Ciesla 2016-11-08 14:19:20 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-HTML-HTML5-Parser
Comment 3 Petr Pisar 2016-11-08 14:37:59 UTC 
Thank you for the review and the repository. I forgot on the double-defined module. Thanks for pointing at it. I removed the unversioned symbol.