| Summary: | subscription-manager doesn't check types of responses during registration API calls | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Chris Snyder <csnyder> |
| Component: | subscription-manager | Assignee: | candlepin-bugs |
| Status: | CLOSED WONTFIX | QA Contact: | John Sefler <jsefler> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 7.5 | CC: | candlepin-bugs, csnyder, it-eng-bz, katello-qa-list, khowell, qianzhan, redakkan, skallesh, weiliu |
| Target Milestone: | pre-dev-freeze | Keywords: | Reopened, Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1390420 | Environment: | |
| Last Closed: | 2021-01-15 07:28:22 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Chris Snyder
2016-11-07 15:29:15 UTC
The purpose of this bug is to investigate subman's handling of errors in the response from CP. In the case of missing keys we should not fail in the manner above. Instead we should present some more useful error message. It might be difficult to actually repro the root cause. A suggestion is to use mitmproxy to remove the 'idCert' property from the response. mitmproxy can be pip installed. For more info see http://mitmproxy.org/ (Or khowell). Note to dev: let's add some defensive coding to two code paths: 1) in `RegisterCommand._determine_owner_key`, check that `owners` as returned by `cp.getOwnerList` is indeed a list (since it comes from http://www.candlepinproject.org/swagger/?url=candlepin/swagger-2.0.13.json#!/owners/list). If it is not, we should raise an error to indicate an issue with the server. 2) similar check to (1) should happen in registergui.py (OrganizationScreen). 3) in `managerlib.persist_consumer_cert`, check that `consumer` as does have `idCert` key. If it does not, we should raise an error to indicate an issue with the server. Red Hat Enterprise Linux 6 is in the Production 3 Phase. During the Production 3 Phase, Critical impact Security Advisories (RHSAs) and selected Urgent Priority Bug Fix Advisories (RHBAs) may be released as they become available. The official life cycle policy can be reviewed here: http://redhat.com/rhel/lifecycle This issue does not meet the inclusion criteria for the Production 3 Phase and will be marked as CLOSED/WONTFIX. If this remains a critical requirement, please contact Red Hat Customer Support to request a re-evaluation of the issue, citing a clear business justification. Note that a strong business justification will be required for re-evaluation. Red Hat Customer Support can be contacted via the Red Hat Customer Portal at the following URL: https://access.redhat.com/ Still a valid request for subscription-manager generally. We'll look at it for RHEL7. After evaluating this issue, there are no plans to address it further or fix it in an upcoming release. Therefore, it is being closed. If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened. |