Bug 1392617

Summary:	UI hangs if errors are encountered during Git Import
Product:	Red Hat CloudForms Management Engine	Reporter:	mkanoor
Component:	Automate	Assignee:	eclarizi
Status:	CLOSED CURRENTRELEASE	QA Contact:	Dmitry Misharov <dmisharo>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	5.7.0	CC:	cpelland, jhardy, mfalesni, mkanoor, obarenbo, tfitzger
Target Milestone:	GA	Keywords:	TestOnly
Target Release:	5.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.8.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1393982 (view as bug list)		Environment:
Last Closed:	2017-06-12 16:04:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1393982

Description mkanoor 2016-11-07 22:01:44 UTC

Description of problem:
After selecting a branch or a tag from a git repository that doesn't conform to the Automate model layout, the UI spinner keeps spinning

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Automate -> Import/Export
2. Use the following repository https://github.com/mkanoor/playbook
3. Click on Submit (this will fetch the repository on to the appliance)
4. Select a branch to import
5. Hit Submit
6. Check the evm.log for errors, you would see a error "Import of Domain failed"


Actual results:
The UI Spinner keeps spinning

Expected results:
the UI should display the proper error message

Additional info:
A similar problem was fixed in PR https://github.com/ManageIQ/manageiq/pull/12080 which was for the first Import/Export Screen generating errors when the user selects submit.

Comment 2 CFME Bot 2016-11-09 15:51:57 UTC

https://github.com/ManageIQ/manageiq/pull/12531

Comment 3 CFME Bot 2016-11-09 19:41:35 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/b44839b82b6702e3a5e997c1be68fdf7d6be0cc6

commit b44839b82b6702e3a5e997c1be68fdf7d6be0cc6
Author:     Erik Clarizio <eclarizi>
AuthorDate: Wed Nov 9 07:38:20 2016 -0800
Commit:     Erik Clarizio <eclarizi>
CommitDate: Wed Nov 9 07:38:20 2016 -0800

    Ensure a response when git repository does not contain domains
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1392617

 app/controllers/miq_ae_tools_controller.rb       |  8 +++++--
 spec/controllers/miq_ae_tools_controller_spec.rb | 30 ++++++++++++++++++++----
 2 files changed, 32 insertions(+), 6 deletions(-)

Comment 4 CFME Bot 2016-11-09 19:41:39 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/bd8353c16ef89c8090637c026b5f48f442177f19

commit bd8353c16ef89c8090637c026b5f48f442177f19
Author:     Erik Clarizio <eclarizi>
AuthorDate: Wed Nov 9 10:50:59 2016 -0800
Commit:     Erik Clarizio <eclarizi>
CommitDate: Wed Nov 9 10:50:59 2016 -0800

    Handle generic exceptions and re-word MiqException::Error message
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1392617

 app/controllers/miq_ae_tools_controller.rb            | 4 ++--
 app/services/git_based_domain_import_service.rb       | 3 ++-
 spec/controllers/miq_ae_tools_controller_spec.rb      | 4 ++--
 spec/services/git_based_domain_import_service_spec.rb | 6 ++++--
 4 files changed, 10 insertions(+), 7 deletions(-)

Comment 6 Milan Falešník 2017-03-03 13:29:59 UTC

Verified in 5.8.0.3.

I get "Error: import failed: Selected branch or tag does not contain a valid domain" when importing the abovementioned repo.