| Summary: | Enable metrics by default | ||
|---|---|---|---|
| Product: | [oVirt] vdsm | Reporter: | Yaniv Bronhaim <ybronhei> |
| Component: | Core | Assignee: | Yaniv Bronhaim <ybronhei> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Jiri Belka <jbelka> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | --- | CC: | bazulay, bmcclain, bugs, didi, gklein, jbelka, lsurette, srevivo, ybronhei, ycui, ykaul |
| Target Milestone: | ovirt-4.1.0-alpha | Flags: | rule-engine:
ovirt-4.1+
bmcclain: priority_rfe_tracking+ ybronhei: devel_ack+ |
| Target Release: | 4.19.2 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-02-01 14:53:38 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1405813 | ||
|
Description
Yaniv Bronhaim
2016-11-08 09:10:51 UTC
The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified. ok
# sed -n '/metrics/,/^$/p' /usr/lib/python2.7/site-packages/vdsm/config.py ; rpm -qf /usr/lib/python2.7/site-packages/vdsm/config.py
# Section: [metrics]
('metrics', [
('enabled', 'true',
'Enable metrics collection (default true)'),
'Number of metrics messages to queue if collector is not'
' responsive. When the queue is full, oldest messages are'
' dropped. Used only by hawkular-client collector (default 100)'),
]),
vdsm-python-4.19.1-29.git40ed539.el7.centos.noarch
Jiri - you just validated that metrics enabled config is set to true by default. the point is to see if the metrics are actually being reported automatically once vdsm is starting (and the rest of the system is configured properly - with collectd running and forwarding it to somewhere that you can check). So in my testings I checked upgrade flow to see if vdsm starts to send metrics after update. new installation. installation without having collectd up - to see if it doesn't generate any issues or error logs anywhere and as stated before, if all set properly, checking if metrics arrive. vdsm sends data to port 8125 which is supposed to be statd. imo validation of metrics data should be supposed to be done in different BZ (iirc there's separate RFE for this) thus this BZ is OK for me. OK? # tcpdump -i lo -n -ttt -A -c 5 port 8125 tcpdump: verbose output suppressed, use -v or -vv for full protocol decode listening on lo, link-type EN10MB (Ethernet), capture size 65535 bytes 00:00:00.000000 IP 127.0.0.1.57083 > 127.0.0.1.8125: UDP, length 21 E..1..@.@.C................0hosts.cpu.load:0.00|g 00:00:00.000047 IP 127.0.0.1.57083 > 127.0.0.1.8125: UDP, length 20 E..0..@.@.C................/hosts.cpu.sys:0.00|g 00:00:00.000013 IP 127.0.0.1.57083 > 127.0.0.1.8125: UDP, length 19 E../..@.@.C.................hosts.vms.total:0|g 00:00:00.000021 IP 127.0.0.1.57083 > 127.0.0.1.8125: UDP, length 35 E..?..@.@.C..............+.>hosts.memory.anon_huge_pages:0.00|g 00:00:00.000011 IP 127.0.0.1.57083 > 127.0.0.1.8125: UDP, length 26 E..6..@.@.C..............".5hosts.cpu.sys_vdsmd:0.00|g 5 packets captured 32 packets received by filter 0 packets dropped by kernel *** Bug 1414277 has been marked as a duplicate of this bug. *** Yes this is prefect. Just wanted to see that the data is sent and not only configured to be sent. Thank you verification confirmed in #6 |