Bug 1392792

Brandon - Please review this issue and pass to the RHEVM team if appropriate.

Latest version tested where the problem still occurs is 5.6.2.2.20161017185613_7cee0a0

HiHo,
can we please raise priority to high, since this is something which used to work with previous versions of 5.6.x and has critical impact for every customer which uses cloud-init (which is probably a lot of OpenStack and RHEV Customers).

Just my 2cents,
Christian

According to the cloud-config docs, the config needs to be valid YAML.  For RHEV, we YAML load, remove the key / value pairs that RHEV requires to be set in a different place and YAML dump everything is left (runcmd included).  The YAML.dump is properly dumping the arrays to valid YAML syntax.

It's interesting that the examples show that the top level is properly YAML dumped but the second level is undumped.  It sounds like a bug in cloudinit.

I have launched an instance directly from the openstack horizon dashboard and provided the cloud-config script attached above. This seems to have worked, even though the user data has also been rewritten:

[root@test ~]# cat /var/lib/cloud/instance/cloud-config.txt
#cloud-config

# from 1 files
# part-001

---
cloud_init_modules:
- migrator
- bootcmd
- write-files
- growpart
- resizefs
- set_hostname
- update_hostname
- update_etc_hosts
- rsyslog
- users-groups
- ssh
output:
    all: '| tee -a /root/install.userdata.log'
runcmd:
-   - cloud-init-per
    - once
    - foreman-userdata
    - /tmp/foreman-userdata.sh
users:
-   name: cloud-user
    ssh_authorized_keys:
    - ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAwsGSFpp7tcOJ3sdT3zU2ek91ew91k69+XjsTIFponydFIa8oxRiFzmM442NRcNRsHmV/OlE/quKaDmtXLeY4NjNDb3xn9AferDjn1hcWDtPBzpfMJe2OMFxNdVxmnwBV49Z2uMA6nixD+CWHBJPkXrBuJ7G24XcuSUocqOQIFmR2YIil4Wnja9ocg4UAft5xcgP7zVom3EWkAZqpuBvzUSPi09GebWa+g567bAvMM8p4oJfeDwzKvx7zZO5rdMI1mgxUp8LlgeQiAnmjHWrCDpc6ZoP8R/YbuC1eLGW2Kb4h1f+rwOiS8kG5uMOuSIV/RkZeUERb7UlZrzBgNOM/DQ==
write_files:
-   content: '#!/bin/bash

        touch /cloud-init_has_run

        '
    path: /tmp/foreman-userdata.sh
    permissions: '0755'
...
[root@test ~]# cat /tmp/foreman-userdata.sh
#!/bin/bash
touch /cloud-init_has_run
[root@test ~]# ls /cloud-init_has_run
/cloud-init_has_run
[root@test ~]#

I just tested again with CFME 5.6.2.2.20161017185613_7cee0a0 -> here the cloud-init script runs just fine.

There are two files in /var/lib/cloud/instance/: user-data.txt and cloud-config.txt. The former contains the runcmd stanza unchanged, the latter has it parsed and reconstituted (nevertheless it works).

This is assigned to me, but I am unclear what the issue is.  cloud-init uses the standard Python YAML parser; as long as it's valid YAML, the particular syntax you use for representing your lists doesn't matter.  The comment in #7 seems to validate this.  The comment in #8 seems to indicate that this problem cannot be reproduced with CFME 5.6.2.2....

Is there still an issue?  If there is, can you provide me with a simple user-data.txt that will reproduce the problem when passed to cloud-init directly (i.e., without involving CFME)?

This problem no longer occurs - might have been a fluke. What is the best way to handle such a case? Should I just comment on it and close it, or leave it open (as I did now)?

I think I'll just close this as CLOSED WORKSFORME.