Bug 1392868

Summary:	The FUSE client log is filling up with posix_acl_default and posix_acl_access messages
Product:	[Community] GlusterFS	Reporter:	rjoseph
Component:	posix-acl	Assignee:	rjoseph
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.8	CC:	bugs, jthottan, olim, rhs-bugs, rjoseph, storage-qa-internal, vbellur
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.6	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1391387	Environment:
Last Closed:	2016-11-29 09:37:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1386366, 1391387
Bug Blocks:

Comment 1 Worker Ant 2016-11-08 11:58:12 UTC

REVIEW: http://review.gluster.org/15799 (posix-acl: check dictionary before using it) posted (#2) for review on release-3.8 by Rajesh Joseph (rjoseph)

Comment 2 Worker Ant 2016-11-09 08:59:52 UTC

REVIEW: http://review.gluster.org/15799 (posix-acl: check dictionary before using it) posted (#3) for review on release-3.8 by Rajesh Joseph (rjoseph)

Comment 3 Worker Ant 2016-11-10 06:26:43 UTC

COMMIT: http://review.gluster.org/15799 committed in release-3.8 by Raghavendra Talur (rtalur) 
------
commit 494dbb8d178b4da925079eea8abeef13df3a129d
Author: Rajesh Joseph <rjoseph>
Date:   Thu Nov 3 14:21:28 2016 +0530

    posix-acl: check dictionary before using it
    
    If extended attributes are not present in md-cache it returns NULL as xattr.
    posix acl xlator should check for NULL before using xattr.
    
    If normal and default ACLs are not set on file then md-cache will not contain
    system.posix_acl_access and system.posix_acl_default extended attributes in
    its cache.
    
    Therefore posix_acl_lookup_cbk should check xattr before using it, otherwise
    the logs will get filled with dictionary errors.
    
    > Reviewed-on: http://review.gluster.org/15769
    > Reviewed-by: Raghavendra Talur <rtalur>
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: jiffin tony Thottan <jthottan>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Reviewed-by: Vijay Bellur <vbellur>
    > CentOS-regression: Gluster Build System <jenkins.org>
    
    (cherry picked from commit de7fe24663713fff364cfc2b52b675e3e979ee68)
    
    Change-Id: Icebf73cf0b313bd3e82ca8cbda63786dd0fa47da
    BUG: 1392868
    Signed-off-by: Rajesh Joseph <rjoseph>
    Reviewed-on: http://review.gluster.org/15799
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra Talur <rtalur>

Comment 4 Niels de Vos 2016-11-29 09:37:17 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.6, please open a new bug report.

glusterfs-3.8.6 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2016-November/000217.html
[2] https://www.gluster.org/pipermail/gluster-users/