| Summary: | Review Request: ocid - OCI-based implementation of Kubernetes Container Runtime Interface | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lokesh Mandvekar <lsm5> | ||||
| Component: | Package Review | Assignee: | Jan Chaloupka <jchaloup> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | nhorman, package-review | ||||
| Target Milestone: | --- | Flags: | jchaloup:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-09-19 12:45:49 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Bug Depends On: | 1393086, 1394018, 1404732 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Lokesh Mandvekar
2016-11-08 15:08:33 UTC
$ sudo dnf builddep ocid.spec Last metadata expiration check: 0:12:17 ago on Tue Nov 8 09:51:53 2016. No matching package to install: 'golang(github.com/Microsoft/go-winio)' No matching package to install: 'golang(github.com/containernetworking/cni/libcni)' No matching package to install: 'golang(github.com/containernetworking/cni/pkg/invoke)' No matching package to install: 'golang(github.com/containernetworking/cni/pkg/types)' No matching package to install: 'golang(github.com/containernetworking/cni/pkg/version)' No matching package to install: 'golang(github.com/containers/image/directory)' No matching package to install: 'golang(github.com/containers/image/directory/explicitfilepath)' No matching package to install: 'golang(github.com/containers/image/docker)' No matching package to install: 'golang(github.com/containers/image/docker/policyconfiguration)' No matching package to install: 'golang(github.com/containers/image/image)' No matching package to install: 'golang(github.com/containers/image/manifest)' No matching package to install: 'golang(github.com/containers/image/oci/layout)' No matching package to install: 'golang(github.com/containers/image/openshift)' No matching package to install: 'golang(github.com/containers/image/transports)' No matching package to install: 'golang(github.com/containers/image/types)' No matching package to install: 'golang(github.com/containers/image/version)' No matching package to install: 'golang(github.com/docker/docker/api/types/blkiodev)' No matching package to install: 'golang(github.com/docker/docker/api/types/container)' No matching package to install: 'golang(github.com/docker/docker/api/types/mount)' No matching package to install: 'golang(github.com/docker/docker/api/types/strslice)' No matching package to install: 'golang(github.com/docker/docker/api/types/versions)' No matching package to install: 'golang(github.com/docker/docker/plugin/getter)' No matching package to install: 'golang(github.com/opencontainers/image-spec/specs-go)' No matching package to install: 'golang(github.com/opencontainers/image-spec/specs-go/v1)' No matching package to install: 'golang(github.com/opencontainers/runtime-tools/generate)' No matching package to install: 'golang(github.com/rajatchopra/ocicni)' No matching package to install: 'golang(golang.org/x/net/internal/timeseries)' No matching package to install: 'golang(google.golang.org/grpc/internal)' No matching package to install: 'golang(k8s.io/kubernetes/pkg/kubelet/api/v1alpha1/runtime)' No matching package to install: 'golang(k8s.io/kubernetes/pkg/selection)' No matching package to install: 'golang(k8s.io/kubernetes/pkg/util/homedir)' using bundled deps, since docker/docker is a build dep which itself has bundled deps. The bundled deps have been marked as such in the devel package. Spec URL: https://lsm5.fedorapeople.org/ocid/ocid.spec When I try to build the rpm, I see this: RPM build errors: Could not open %files file /home/lsm5/repositories/pkgs/reviews/ocid/BUILD/cri-o-c57530eb4769fbc2c91d89e7d5ce48a740f812ee/unit-test-devel.file-list: No such file or directory No idea why. Created attachment 1232165 [details]
Godeps,json for deps
Spec URL: https://lsm5.fedorapeople.org/ocid/ocid.spec Godeps.json: https://lsm5.fedorapeople.org/ocid/Godeps.json Spec URL: https://lsm5.fedorapeople.org/ocid/ocid.spec Godeps.json: https://lsm5.fedorapeople.org/ocid/Godeps.json Spec URL: https://lsm5.fedorapeople.org/ocid/SRPMS/ocid-0-0.2.gitc57530e.fc25.src.rpm disabled unit tests koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=16901123 Spec URL: https://lsm5.fedorapeople.org/ocid/ocid.spec Godeps.json: https://lsm5.fedorapeople.org/ocid/Godeps.json Spec URL: https://lsm5.fedorapeople.org/ocid/SRPMS/ocid-0-0.3.gitc57530e.fc25.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=16901430 Spec URL: https://lsm5.fedorapeople.org/ocid/ocid.spec ..devel disabled. Given only binaries are built, the spec file conforms to the current packaging guidelines. However, I would recommend to update the spec file with: - replace make all in %build section with actual commands so the LDFLAGS can be set and %gobuild macro used instead of go command - partial unbundle the deps (the package depends on kubernetes and docker which are by its nature unbundeable at the moment) - once the intel issue is fixed (worth openning upstream issue/bz for it), extend the list of supported architectures to all supported - provide Godeps.json (or its variant) as a part of the devel subpackage once https://github.com/kubernetes-incubator/cri-o/issues/280 is resolved and the devel rpm is built. ocid-0-0.3.gitc57530e.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b2562cef01 ocid-0-0.3.gitc57530e.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e27ec90884 ocid-0-0.3.gitc57530e.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b2562cef01 ocid-0-0.3.gitc57530e.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e27ec90884 ocid-0-0.7.git2e6070f.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-59e06d79d7 ocid-0-0.7.git2e6070f.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b9d15b70db ocid-0-0.7.git2e6070f.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b9d15b70db ocid-0-0.7.git2e6070f.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-59e06d79d7 lokesh, is it possible to enable ppc64le and aarch64 on this package? ocid-0-0.8.git2e6070f.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d4f51b1502 ocid-0-0.8.git2e6070f.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e3922e19df ocid-0-0.8.git2e6070f.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e3922e19df ocid-0-0.8.git2e6070f.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d4f51b1502 Package retired in favor of cri-o |