| Summary: | Status card content should not wrap | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine-dashboard | Reporter: | Vojtech Szocs <vszocs> | ||||||
| Component: | General | Assignee: | Scott Dickerson <sdickers> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Lucie Leistnerova <lleistne> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | unspecified | CC: | bugs, gshereme, lleistne, oourfali, pstehlik, vszocs | ||||||
| Target Milestone: | ovirt-4.1.1 | Flags: | rule-engine:
ovirt-4.1+
rule-engine: planning_ack+ oourfali: devel_ack+ pstehlik: testing_ack+ |
||||||
| Target Release: | 1.1.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2017-04-21 09:39:17 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | UX | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Attachments: |
|
||||||||
Vojtech - isn't this a restating of BZ 1369550? We want the status cards, including content, to all be the same height. The width of the cards are controlled by widths on the card's containers. I'd rather see the contents of the card wrap internally and then all of the cards have their internal heights adjusted to match. That way the widths stay the same. I can add some styles so the icons don't wrap without their text. That should help the visuals. (In reply to Scott Dickerson from comment #1) > Vojtech - isn't this a restating of BZ 1369550? This BZ was meant to fix the "uncontrolled wrapping" issue, see the attached screenshot. [The "up" icon is not on the same row as the corresponding "up" text/number.] If this can be fixed via BZ 1369550, feel free to close this one. > We want the status cards, including content, to all be the same height. The > width of the cards are controlled by widths on the card's containers. > > I'd rather see the contents of the card wrap internally and then all of the > cards have their internal heights adjusted to match. That way the widths > stay the same. I can add some styles so the icons don't wrap without their > text. That should help the visuals. As for the wrapping: we either allow it across [icon + number] pairs (aka "controlled wrapping"), or disallow it (to have everything in one row). We should probably ask PatternFly team what's the recommended approach. As for the same height: please see my comment https://bugzilla.redhat.com/show_bug.cgi?id=1369550#c2 PatternFly status card reference: http://www.patternfly.org/pattern-library/cards/aggregate-status-card/ After discussing the issue with Serena in the PatternFly Group, the recommendation is to allow content wrapping, but do not all the icon and count text to break across lines. BZ1369550 forces all the cards to match title and content height. Wrapped content looks better when all of the aggregate status card's heights are matched. When I resize browser window the icon with count text in events still wraps. See attachment. tested in ovirt-engine-dashboard-1.1.0-5.el7ev.x86_64 Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. Created attachment 1256507 [details]
events count text wraps
Lucie - Can you tell me what browser and version you tested on? I verified the fix worked on current versions of IE, Chrome and FF. Firefox 51.0.1 on Fedora 24, Google Chrome 56.0 doesn't wrap Firefox doesn't wrap neither after yum update (no Firefox update) of my Fedora and reboot, so It was about my system. verified in ovirt-engine-dashboard-1.1.0-5.el7ev.x86_64 |
Created attachment 1218602 [details] Status card content wrap example Icons and numbers representing objects with different statuses (up, down, warning, etc.) should not wrap to the next line. This is to keep a consistent inner layout of all status cards. Please see the attached screenshot for reference.