Bug 1393174

Summary: Database Integrity Distro Library os_version
Product: [Retired] Beaker Reporter: Tyrone Abdy <tabdy>
Component: generalAssignee: Dan Callaghan <dcallagh>
Status: CLOSED CURRENTRELEASE QA Contact: tools-bugs <tools-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: developCC: dcallagh, mjia, rjoost
Target Milestone: 25.0Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-19 04:18:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tyrone Abdy 2016-11-09 03:27:01 UTC
Description of problem:
On table os_version osmajor_id is nullable which could lead to orphaned data.
This should be updated to make nullable=False. As part of the migration script deleting the potential orphaned data could be required.

Comment 1 Dan Callaghan 2017-12-20 05:52:26 UTC
On a recent production snapshot:

MySQL [beaker_dcallagh]> select count(*) from osversion where osmajor_id is null;
+----------+
| count(*) |
+----------+
|        0 |
+----------+
1 row in set (0.00 sec)

Comment 2 Dan Callaghan 2017-12-20 06:49:13 UTC
https://gerrit.beaker-project.org/5958

Comment 4 Dan Callaghan 2018-01-10 03:28:17 UTC
There is no expected change in behaviour here, so verification should just be that the database migration succeeds (it did) and that nothing else breaks.

Comment 6 Roman Joost 2018-03-19 04:18:59 UTC
Beaker 25.0 has been released.

Release notes are available upstream: https://beaker-project.org/docs/whats-new/release-25.html